1872311 - Fix videoFrame-createImageBitmap.https.any.js failure

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect, P2)

Description

[C.M.Chang[:chunmin]]

videoFrame-createImageBitmap.https.any.js is currently failed. The pixel bytes of the image generated from the encoded-then-decoded are sometimes 0 (e.g., at the index 3000), so the comparison fails.

Comment 1

[C.M.Chang[:chunmin]]

Besides, XPCOM_MEM_BLOAT_LOG appears in the logs with rdd, which might relate to bug 1871768

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:padenot, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

We create a canvas of size 1280x720:
https://searchfox.org/mozilla-central/rev/ae3df68e9ba2faeaf76445a7650e4e742eb7b4e7/testing/web-platform/tests/webcodecs/videoFrame-createImageBitmap.https.any.js#6

We set an arbitrary size here:
https://searchfox.org/mozilla-central/rev/ae3df68e9ba2faeaf76445a7650e4e742eb7b4e7/dom/media/webcodecs/VideoDecoder.cpp#761

We calculate the aspect ratio (4/3) of that arbitrary size:
https://searchfox.org/mozilla-central/rev/ae3df68e9ba2faeaf76445a7650e4e742eb7b4e7/dom/media/platforms/wrappers/MediaChangeMonitor.cpp#321

And then we apply that arbitrary aspect ratio to the actual size (1280x720) to get a display size of 960x720:
https://searchfox.org/mozilla-central/rev/ae3df68e9ba2faeaf76445a7650e4e742eb7b4e7/dom/media/platforms/wrappers/MediaChangeMonitor.cpp#404

When we draw the end result, we use the display size of 960x720 as per the spec:
https://searchfox.org/mozilla-central/rev/ae3df68e9ba2faeaf76445a7650e4e742eb7b4e7/testing/web-platform/tests/webcodecs/videoFrame-createImageBitmap.https.any.js#23

That means we never write the pixels in columns 961-1280, and the assertion fails.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1872311 - Prefer to use frame size as display size with WebCodecs.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03d1aa84a0fa
Prefer to use frame size as display size with WebCodecs. r=chunmin

Comment 6

[Cristian Tuns]

Backed out for causing wpt failures in videoFrame-createImageBitmap.https.any.worker.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /webcodecs/videoFrame-createImageBitmap.https.any.worker.html | Create ImageBitmap for a VideoFrame from VP9 decoder. - promise_test: Unhandled rejection with value: object "NotSupportedError: Operation is not supported"

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2c0a33fe505
Prefer to use frame size as display size with WebCodecs. r=chunmin

Comment 8

[Iulian Moraru]

Backed out for causing wpt failures related to webcodecs.

• Push with failures

• Failure log example 1

• Failure log example 2

• Backout link

Comment 9

[Pulsebot]

Backout by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/f256df2559ba
Backed out changeset d2c0a33fe505 for causing wpt failures related to webcodecs.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b274ea0f726
Prefer to use frame size as display size with WebCodecs. r=chunmin

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8b274ea0f726