1872509 - checkbox is missing its check-mark, in leesa.com mattress checkout form

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Add something to your cart at leesa.com, e.g. this mattress (click "add to cart" on right side)
2. Click the "Secure Checkout" button that appears
3. Look at the Email me with news and offers checkbox

ACTUAL RESULTS:
The box is filled in, but the checkmark is missing

EXPECTED RESULTS:
The checkmark should be there.

This is a pretty recent regression; mozregression says this was from bug 1800077.

Last good revision: d476b321db898ab16351baeaabf2cc1bed447c68
First bad revision: 6a14f603289807a62753cc8ceaa35d9ba09cbf61
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d476b321db898ab16351baeaabf2cc1bed447c68&tochange=6a14f603289807a62753cc8ceaa35d9ba09cbf61

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot (Chrome on left, Firefox Nighlty on right)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: checkbox-tick SVG resource used in testcase

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1800077

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1872509 - Don't clip checkbox/radio overflow. r=dholbert,zcorpan,#layout

Since it's not web-compatible. I had already brought this possibility up
in the comments of https://github.com/whatwg/html/pull/10025, so will
update that PR accordingly.

Remove forceful overflow: hidden for file / date inputs, which was
caught by the tests in the next patch.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1872509 - Extend tests for input UA styles. r=dholbert,zcorpan,#layout

This probably needs to wait for that PR to be merged since unlike the
range tests, these actually test the clip value.

Depends on D197456

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30b0d1ecdc26
Don't clip checkbox/radio overflow. r=dholbert

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/30b0d1ecdc26

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2983016a298e
Extend tests for input UA styles. r=dholbert

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44002 for changes under testing/web-platform/tests

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2983016a298e

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Monica Chiorean]

I was able to reproduce the issue on Win10x64 using FF build 123.0a1(20231230213730) and steps from description.
Verified as fixed on Win10/Mac12.6/Ubuntu 22.04 using Firefox build 123.0b5, 124.0a1(20240202094312).