1872535 - CSS Highlights API bug when deleting and adding ranges

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect)

Description

[Roman Komarov]

Attachment: CodePen - CSS highlights API bug.html

To reproduce (testing in 123.0a1 (2023-12-31) (64-bit)):

1. Go to https://codepen.io/kizu/pen/WNmQrBW?editors=1010 (or open an attached .html)
2. Click the button.
3. Blur the button by clicking elsewhere.

What happened:

• After step 2: the first word is fully highlighted, the second half of the second word is highlighted.
• After step 3: the second word is not highlighted, the first word is fully highlighted.

What is expected:

• There should be no visual changes: removing a range, then adding the same range should not have any impact. Safari and Chrome seem to work the same.

Comment 1

[Jan Jaeschke [:jjaschke]]

Hi Roman,

Thank you for your report. I’ll investigate!

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1872535: Deal with invalid `StaticRange`s and DOM mutations in `Selection`. r=#dom-core,smaug!

Ranges inside of a Selection are expected to be sorted by their start point by the painting algorithms. Also, StaticRanges, which previously were not part of Selection, need to be considered for painting based on their IsValid() status.

This is now added by introducing a second array for invalid static ranges and an additional re-ordering method which needs to be called before paint that moves ranges in between.
A potential change in range endpoints can be determined by observing the Documents generation and by adding a flag that's set to true in Selection::NotifySelectionObservers().

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20e975d790c8
Deal with invalid `StaticRange`s and DOM mutations in `Selection`. r=smaug

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44141 for changes under testing/web-platform/tests

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/20e975d790c8

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-01-19 Nightly build on macOS 12.
Verified as fixed on Firefox 124.0b2 and Nightly 125.0a1 on macOS 12, Windows 10, Ubuntu 22.