1872683 - ESLint Jest failures when upgrading eslint-plugin-jest to v27.6.1

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Mark Banner (:standard8)]

As part of regularly upgrading ESLint, and heading towards ESLint v9, I'm attempting to ensure our packages our updated, so that we can pick up any v9 specific changes ahead of time, to make updating easier.

When I update eslint-plugin-jest to v27.6.1, there are a number of failures that are present.

Please can someone take a look at fixing these?

To do the upgrade locally:

• Update package.json to set eslint-plugin-jest to "27.6.1"
• Update devtools/client/debugger/src/.eslintrc.js to include this snippet at the top-level of the module.exports:

  settings: {
    jest: {
      version: 27,
    },
  },

• Run rm -r node_modules package-lock.json && ./mach npm install to regenerate the node modules installation.
• Run ESLint as normal, e.g. ./mach eslint . or ./mach eslint devtools/client/debugger

The current errors are below. Some of these are automatically fixable with --fix.

devtools/client/debugger/src/actions/sources/tests/blackbox.spec.js
  15:6  error  should not have leading or trailing spaces  jest/valid-title (eslint)

devtools/client/debugger/src/components/Editor/Preview/tests/Popup.spec.js
   33:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect (eslint)
   38:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect (eslint)
   99:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect (eslint)
  104:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect (eslint)

devtools/client/debugger/src/components/Editor/tests/ConditionalPanel.spec.js
  65:6  error  should not have duplicate prefix  jest/valid-title (eslint)
  69:6  error  should not have duplicate prefix  jest/valid-title (eslint)
  73:6  error  should not have duplicate prefix  jest/valid-title (eslint)

devtools/client/debugger/src/components/shared/Button/tests/PaneToggleButton.spec.js
  39:6  error  should not have leading or trailing spaces  jest/valid-title (eslint)

devtools/client/debugger/src/reducers/tests/breakpoints.spec.js
  17:6  error  should not have duplicate prefix  jest/valid-title (eslint)
  41:6  error  should not have duplicate prefix  jest/valid-title (eslint)

devtools/client/debugger/src/utils/breakpoint/tests/index.spec.js
  10:6  error  should not have leading or trailing spaces  jest/valid-title (eslint)

devtools/client/debugger/src/utils/editor/tests/source-documents.spec.js
  27:8  error  should not have leading or trailing spaces  jest/valid-title (eslint)

devtools/client/debugger/src/utils/tests/result-list.spec.js
  19:6  error  should not have leading or trailing spaces  jest/valid-title (eslint)

devtools/client/debugger/src/workers/pretty-print/tests/prettyFast.spec.js
  415:8  error  Title must be a string  jest/valid-title (eslint)

devtools/client/debugger/src/workers/search/tests/get-matches.spec.js
  53:8  error  should not have duplicate prefix  jest/valid-title (eslint)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

I'll have a look

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1872683 - [devtools] Prepare debugger jest test for eslint-plugin-jest 27.6.1 update. r=Standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a6deecdb288
[devtools] Prepare debugger jest test for eslint-plugin-jest 27.6.1 update. r=Standard8,devtools-reviewers,ochameau

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1a6deecdb288