1872858 - Webgpu demo freezes browser UI and if you open about:support, it is blank

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebGPU, defect)

Description

[Mayank Bansal]

Use latest Nightly on Windows
Go to https://yuu6883.github.io////WebGPUDemo/?cloth
Try resizing the browser window
OR, open about:support

AR: Browser UI freezes . If you open about:support, then the rows are blank

Regresion range :

Bug 1859999 - Update wgpu to revision 75989192a9c8f70893882ce0f4373ac217d380c3. r=webgpu-reviewers,supply-chain-reviewers,nical

Differential Revision: https://phabricator.services.mozilla.com/D191400

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

Attachment: bug.png

Empty about:support

Comment 3

[Mayank Bansal]

Attachment: log.txt-main.12904.moz_log

gfx+webgpu logs

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1859999

:teoxoy, since you are the author of the regressor, bug 1859999, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Teodor Tanasoaia [:teoxoy]]

I tried reproducing the blank about:support but it worked for me, could someone else also try?

The regressor is the wgpu update that brought in const-expression support which is the functionality that was blocking the example from working.
It now fails later with a different error but doesn't cause the browser to freeze when resized.

The example does take a long time to start.

Comment 6

[Mayank Bansal]

https://share.firefox.dev/3tOZrRs
This may be more reproducible if you try to capture a Gecko profile while the demo is opened..

I also get these 2 crashes sometimes :
https://crash-stats.mozilla.org/report/index/6605ee32-35bf-4c67-913d-49bb90240103
https://crash-stats.mozilla.org/report/index/541bec33-b4c9-423e-a6f5-aebbd0240103#tab-bugzilla

Comment 7

[Mayank Bansal]

If I disable remote canvas, subjectively it feels much better.. There is no UI hang etc.

https://share.firefox.dev/48mbAMO

The symptoms seem to hint at the recent canvas-y changes.

Comment 8

[Bob Hood [:bhood]]

Lee, any sense of off-main-thread impact here?

Comment 9

[Lee Salzman [:lsalzman]]

No idea, my changes would not touch webgpu.

Comment 10

[Mayank Bansal]

Attachment: output from a debug build that crashed on the demo

Comment 11

[Mayank Bansal]

Attachment: log.txt-main.2428.moz_log

moar logging

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1859999

Comment 14

[Erich Gubler [:ErichDonGubler] (he/him)]

:nical: Is the second crash link from Mayank maybe related to the eager texture destruction issue you filed at gfx-rs/wgpu#5079?

Comment 15

[Nicolas Silva [:nical]]

The issue I filed is about internal hal resource lifetime whereas this crash is happening one level above, in the registry.
The ID is invalid. That suggests that somehow IPC messages are dropped or reordered or that we are trying to reuse an ID from before a GPU process crash after we re-create it.

About the original issue, it looks like shaders are taking forever to compile (presumably FXC's known struggles), which blocks the canvas renderer thread. Since remote canvas also uses the canvas renderer thread, it's likely that the compositor is waiting for that the remote canvas work to finish but the latter is blocked until the shader is compiled as collateral damage from being on the same thread as WebGPU.

Comment 16

[Mayank Bansal]

I see similar issue on other WebGPU demo like : https://martinlaxenaire.github.io/gpu-curtains/

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.

Comment 19

[Mayank Bansal]

This bug is not about crashes, but about hangs.
I can still repro the blank about:support

Comment 20

[Mayank Bansal]

The demo still takes a long time to render: https://share.firefox.dev/3ZsmIEU

Comment 21

[Mayank Bansal]

Demo doesnt render.

Error in console:

15:36:54.187 injected firefox content.js:239:17
15:36:54.269
GPUSupportedLimits { maxTextureDimension1D: 8192, maxTextureDimension2D: 8192, maxTextureDimension3D: 2048, maxTextureArrayLayers: 256, maxBindGroups: 4, maxBindGroupsPlusVertexBuffers: 12, maxBindingsPerBindGroup: 1000, maxDynamicUniformBuffersPerPipelineLayout: 8, maxDynamicStorageBuffersPerPipelineLayout: 4, maxSampledTexturesPerShaderStage: 16 }
index.js:2:250375
15:36:55.724 Uncaptured WebGPU error: In a set_viewport command, caused by: Viewport has invalid rect Rect { x: 0.0, y: 0.0, w: 2239.5, h: 1399.5 }; origin and/or size is less than or equal to 0, and/or is not contained in the render target (2239, 1399, 1)
15:36:55.724 Uncaptured WebGPU error: Command encoder is invalid
15:36:55.724 Uncaptured WebGPU error: CommandBuffer with '' label is invalid
15:36:55.752 Total cloth triangles: 7938 index.js:2:193807
15:36:55.752
GPUSupportedLimits { maxTextureDimension1D: 8192, maxTextureDimension2D: 8192, maxTextureDimension3D: 2048, maxTextureArrayLayers: 256, maxBindGroups: 4, maxBindGroupsPlusVertexBuffers: 12, maxBindingsPerBindGroup: 1000, maxDynamicUniformBuffersPerPipelineLayout: 8, maxDynamicStorageBuffersPerPipelineLayout: 4, maxSampledTexturesPerShaderStage: 16 }
index.js:2:252055
15:37:00.633
Unknown property ‘-moz-transition’. Declaration dropped. WebGPUDemo:1:258
15:37:00.633
Unknown property ‘-moz-transition’. Declaration dropped. WebGPUDemo:1:679
15:37:00.633
Unknown property ‘-moz-transition’. Declaration dropped. WebGPUDemo:1:1377
15:37:00.633
Unknown property ‘-moz-transition’. Declaration dropped. WebGPUDemo:1:1517
15:37:00.633
Unknown property ‘-moz-transition’. Declaration dropped. WebGPUDemo:1:258
15:37:00.633
Unknown property ‘-moz-transition’. Declaration dropped. WebGPUDemo:1:679
15:37:00.633
Unknown property ‘-moz-transition’. Declaration dropped. WebGPUDemo:1:1377
15:37:00.633
Unknown property ‘-moz-transition’. Declaration dropped.

Comment 22

[Mayank Bansal]

I guess the original issue of browser freezing is fixed. For the demo not rendering, should I file a new bug, or can this bug be repurposed?

Comment 23

[Nicolas Silva [:nical]]

Thanks Mayank, please file a new bug for this, it'll be easier to navigate without context about older issues (FWIW the demo runs well on my on linux and windows laptops).

Comment 24

[Mayank Bansal]

(In reply to Nicolas Silva [:nical] from comment #23)

Thanks Mayank, please file a new bug for this, it'll be easier to navigate without context about older issues (FWIW the demo runs well on my on linux and windows laptops).

Filed bug 1941976.