1872871 - Split FFmpegVideoEncoder initailization into smaller functions

Status: RESOLVED FIXED

(Core :: Audio/Video, task, P1)

Description

[C.M.Chang[:chunmin]]

The initialization of FFmpegVideoEncoder is getting bigger and bigger once we apply more codec-specific settings and patches in bug 1870216. To improve the readability, it's better to move those settings into smaller helper functions (See https://phabricator.services.mozilla.com/D196534?id=805071#inline-1096610).

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1872871 - Move SVC settings to a function

This patch addresses an earlier review comment [1] in the code.

Shortening the init function, by moving the SVC settings to a helper
function, improves the readability.

[1] https://phabricator.services.mozilla.com/D196534?id=805071#inline-1096610

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1872871 - Move codec-specific settings to a function

This patch addresses an earlier review comment [1] in the code.

Shortening the init function, by moving the codec-specific settings to a
helper function, improves the readability.

[1] https://phabricator.services.mozilla.com/D196534?id=805071#inline-1096610

Depends on D202606

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1872871 - Move media-usage settings to a function

This patch addresses an earlier review comment [1] in the code.

Shortening the init function, by moving the media-usage settings to a
helper function, improves the readability.

[1] https://phabricator.services.mozilla.com/D196534?id=805071#inline-1096610

Depends on D202607

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7320c6c77a0c
Move SVC settings to a function r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/636cf8095a0f
Move codec-specific settings to a function r=media-playback-reviewers,padenot

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7320c6c77a0c
https://hg.mozilla.org/mozilla-central/rev/636cf8095a0f