Closed
Bug 1872933
Opened 8 months ago
Closed 8 months ago
Perma Windows MinGW all [tier 2] /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:304:28: error: use of undeclared identifier 'StoreProductResult'
Categories
(Firefox :: Installer, defect, P5)
Firefox
Installer
Tracking
()
RESOLVED
FIXED
123 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox121 | --- | unaffected |
| firefox122 | --- | unaffected |
| firefox123 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Unassigned)
References
(Regression)
Details
(Keywords: intermittent-failure, regression)
Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=442070437&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/BIrduVV5Rdq2yCrdKfuTgQ/runs/0/artifacts/public/logs/live_backing.log
[task 2024-01-03T22:02:35.565Z] 22:02:35 INFO - gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/system/windowsPackageManager'
[task 2024-01-03T22:02:35.568Z] 22:02:35 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/i686-w64-mingw32-clang++ -o nsWindowsPackageManager.o -c -I/builds/worker/workspace/obj-build/dist/stl_wrappers -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager -I/builds/worker/workspace/obj-build/toolkit/system/windowsPackageManager -I/builds/worker/checkouts/gecko/toolkit/components/jsoncpp/include -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -fno-sized-deallocation -fno-aligned-new -fms-extensions -fcrash-diagnostics-dir=/builds/worker/artifacts -include _mingw.h -D_HAS_EXCEPTIONS=0 -fno-exceptions -Wno-incompatible-ms-struct -mstackrealign -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off -MD -MP -MF .deps/nsWindowsPackageManager.o.pp /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp
[task 2024-01-03T22:02:35.568Z] 22:02:35 INFO - In file included from /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:7:
[task 2024-01-03T22:02:35.569Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/Promise.h:21:
[task 2024-01-03T22:02:35.569Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/WeakPtr.h:88:
[task 2024-01-03T22:02:35.571Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/nsProxyRelease.h:20:
[task 2024-01-03T22:02:35.571Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:15:
[task 2024-01-03T22:02:35.571Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/EventQueue.h:12:
[task 2024-01-03T22:02:35.572Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/TimeStamp.h:27:
[task 2024-01-03T22:02:35.572Z] 22:02:35 WARNING - /builds/worker/workspace/obj-build/dist/include/mozilla/TimeStamp_windows.h:53:13: warning: 'dllimport' attribute ignored on inline function [-Wignored-attributes]
[task 2024-01-03T22:02:35.572Z] 22:02:35 INFO - 53 | constexpr MFBT_API TimeStampValue(uint64_t aGTC, uint64_t aQPC, bool aHasQPC)
[task 2024-01-03T22:02:35.573Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.575Z] 22:02:35 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:101:24: note: expanded from macro 'MFBT_API'
[task 2024-01-03T22:02:35.575Z] 22:02:35 INFO - 101 | # define MFBT_API MOZ_IMPORT_API
[task 2024-01-03T22:02:35.575Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.575Z] 22:02:35 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:63:39: note: expanded from macro 'MOZ_IMPORT_API'
[task 2024-01-03T22:02:35.575Z] 22:02:35 INFO - 63 | # define MOZ_IMPORT_API __declspec(dllimport)
[task 2024-01-03T22:02:35.576Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.576Z] 22:02:35 INFO - In file included from /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:7:
[task 2024-01-03T22:02:35.576Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/Promise.h:21:
[task 2024-01-03T22:02:35.576Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/WeakPtr.h:88:
[task 2024-01-03T22:02:35.577Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/nsProxyRelease.h:20:
[task 2024-01-03T22:02:35.577Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:15:
[task 2024-01-03T22:02:35.577Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/EventQueue.h:12:
[task 2024-01-03T22:02:35.577Z] 22:02:35 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/TimeStamp.h:27:
[task 2024-01-03T22:02:35.578Z] 22:02:35 WARNING - /builds/worker/workspace/obj-build/dist/include/mozilla/TimeStamp_windows.h:62:26: warning: 'dllimport' attribute ignored on inline function [-Wignored-attributes]
[task 2024-01-03T22:02:35.578Z] 22:02:35 INFO - 62 | constexpr MOZ_IMPLICIT MFBT_API TimeStampValue(uint64_t aGTCAndQPC)
[task 2024-01-03T22:02:35.579Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.583Z] 22:02:35 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:101:24: note: expanded from macro 'MFBT_API'
[task 2024-01-03T22:02:35.584Z] 22:02:35 INFO - 101 | # define MFBT_API MOZ_IMPORT_API
[task 2024-01-03T22:02:35.587Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.589Z] 22:02:35 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:63:39: note: expanded from macro 'MOZ_IMPORT_API'
[task 2024-01-03T22:02:35.590Z] 22:02:35 INFO - 63 | # define MOZ_IMPORT_API __declspec(dllimport)
[task 2024-01-03T22:02:35.591Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.591Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:304:28: error: use of undeclared identifier 'StoreProductResult'
[task 2024-01-03T22:02:35.591Z] 22:02:35 INFO - 304 | ComPtr<IAsyncOperation<StoreProductResult*> > asyncSpr,
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.592Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:304:47: error: expected expression
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - 304 | ComPtr<IAsyncOperation<StoreProductResult*> > asyncSpr,
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.592Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:305:12: error: unknown type name 'IStoreContext'; did you mean 'AutoJSContext'?
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - 305 | ComPtr<IStoreContext> storeContext,
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - | ^~~~~~~~~~~~~
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - | AutoJSContext
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ScriptSettings.h:351:16: note: 'AutoJSContext' declared here
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - 351 | class MOZ_RAII AutoJSContext {
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.592Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:305:5: error: no template named 'ComPtr'
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - 305 | ComPtr<IStoreContext> storeContext,
[task 2024-01-03T22:02:35.592Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.593Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:307:10: error: use of undeclared identifier 'IStoreProductResult'
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - 307 | ComPtr<IStoreProductResult> productResult = nullptr;
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.593Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:317:10: error: use of undeclared identifier 'IStoreProduct'
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - 317 | ComPtr<IStoreProduct> product = nullptr;
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.593Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:317:25: error: use of undeclared identifier 'product'; did you mean 'nsGkAtoms::product_'?
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - 317 | ComPtr<IStoreProduct> product = nullptr;
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - | ^~~~~~~
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - | nsGkAtoms::product_
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - /builds/worker/workspace/obj-build/dist/include/nsGkAtomList.h:1813:9: note: 'nsGkAtoms::product_' declared here
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - 1813 | GK_ATOM(product_, "product", 0x693213a0, true, nsStaticAtom, Atom)
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.593Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:318:36: error: use of undeclared identifier 'product'; did you mean 'nsGkAtoms::product_'?
[task 2024-01-03T22:02:35.593Z] 22:02:35 INFO - 318 | hr = productResult->get_Product(&product);
[task 2024-01-03T22:02:35.594Z] 22:02:35 INFO - | ^~~~~~~
[task 2024-01-03T22:02:35.594Z] 22:02:35 INFO - | nsGkAtoms::product_
[task 2024-01-03T22:02:35.594Z] 22:02:35 INFO - /builds/worker/workspace/obj-build/dist/include/nsGkAtomList.h:1813:9: note: 'nsGkAtoms::product_' declared here
[task 2024-01-03T22:02:35.594Z] 22:02:35 INFO - 1813 | GK_ATOM(product_, "product", 0x693213a0, true, nsStaticAtom, Atom)
[task 2024-01-03T22:02:35.594Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.595Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:319:25: error: use of undeclared identifier 'product'; did you mean 'nsGkAtoms::product_'?
[task 2024-01-03T22:02:35.595Z] 22:02:35 INFO - 319 | if (SUCCEEDED(hr) && (product != nullptr)) {
[task 2024-01-03T22:02:35.595Z] 22:02:35 INFO - | ^~~~~~~
[task 2024-01-03T22:02:35.596Z] 22:02:35 INFO - | nsGkAtoms::product_
[task 2024-01-03T22:02:35.596Z] 22:02:35 INFO - /builds/worker/workspace/obj-build/dist/include/nsGkAtomList.h:1813:9: note: 'nsGkAtoms::product_' declared here
[task 2024-01-03T22:02:35.596Z] 22:02:35 INFO - 1813 | GK_ATOM(product_, "product", 0x693213a0, true, nsStaticAtom, Atom)
[task 2024-01-03T22:02:35.596Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.597Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:320:12: error: use of undeclared identifier 'Collections'
[task 2024-01-03T22:02:35.597Z] 22:02:35 INFO - 320 | ComPtr<Collections::IVectorView<StoreSku*> > skus = nullptr;
[task 2024-01-03T22:02:35.597Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.598Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:320:46: error: expected expression
[task 2024-01-03T22:02:35.598Z] 22:02:35 INFO - 320 | ComPtr<Collections::IVectorView<StoreSku*> > skus = nullptr;
[task 2024-01-03T22:02:35.598Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.598Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:320:37: error: use of undeclared identifier 'StoreSku'
[task 2024-01-03T22:02:35.598Z] 22:02:35 INFO - 320 | ComPtr<Collections::IVectorView<StoreSku*> > skus = nullptr;
[task 2024-01-03T22:02:35.599Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.599Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:320:50: error: use of undeclared identifier 'skus'
[task 2024-01-03T22:02:35.599Z] 22:02:35 INFO - 320 | ComPtr<Collections::IVectorView<StoreSku*> > skus = nullptr;
[task 2024-01-03T22:02:35.599Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.600Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:321:10: error: use of undeclared identifier 'product'
[task 2024-01-03T22:02:35.600Z] 22:02:35 INFO - 321 | hr = product->get_Skus(&skus);
[task 2024-01-03T22:02:35.600Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.600Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:321:29: error: use of undeclared identifier 'skus'
[task 2024-01-03T22:02:35.600Z] 22:02:35 INFO - 321 | hr = product->get_Skus(&skus);
[task 2024-01-03T22:02:35.600Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.601Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:322:27: error: use of undeclared identifier 'skus'
[task 2024-01-03T22:02:35.601Z] 22:02:35 INFO - 322 | if (!SUCCEEDED(hr) || skus == nullptr) {
[task 2024-01-03T22:02:35.601Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.601Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:328:10: error: use of undeclared identifier 'skus'
[task 2024-01-03T22:02:35.601Z] 22:02:35 INFO - 328 | hr = skus->get_Size(&size);
[task 2024-01-03T22:02:35.601Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.602Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:335:14: error: use of undeclared identifier 'IStoreSku'
[task 2024-01-03T22:02:35.602Z] 22:02:35 INFO - 335 | ComPtr<IStoreSku> sku = nullptr;
[task 2024-01-03T22:02:35.602Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.602Z] 22:02:35 ERROR - /builds/worker/checkouts/gecko/toolkit/system/windowsPackageManager/nsWindowsPackageManager.cpp:336:12: error: use of undeclared identifier 'skus'
[task 2024-01-03T22:02:35.602Z] 22:02:35 INFO - 336 | hr = skus->GetAt(i, &sku);
[task 2024-01-03T22:02:35.602Z] 22:02:35 INFO - | ^
[task 2024-01-03T22:02:35.603Z] 22:02:35 INFO - fatal error: too many errors emitted, stopping now [-ferror-limit=]
[task 2024-01-03T22:02:35.603Z] 22:02:35 INFO - 2 warnings and 20 errors generated.
[task 2024-01-03T22:02:35.603Z] 22:02:35 ERROR - gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:690: nsWindowsPackageManager.o] Error 1
[task 2024-01-03T22:02:35.603Z] 22:02:35 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/system/windowsPackageManager'
[task 2024-01-03T22:02:35.603Z] 22:02:35 INFO - gmake[4]: Target 'target-objects' not remade because of errors.
[task 2024-01-03T22:02:35.604Z] 22:02:35 ERROR - gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: toolkit/system/windowsPackageManager/target-objects] Error 2
[task 2024-01-03T22:02:35.604Z] 22:02:35 INFO - gmake[4]: Entering directory '/builds/worker/workspace/obj-build/xpcom/threads'
[task 2024-01-03T22:02:35.604Z] 22:02:35 INFO - xpcom/threads/IdleTaskRunner.o
[task 2024-01-03T22:02:35.604Z] 22:02:35 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/xpcom/threads'
|
||
Comment 1•8 months ago
|
||
Hi Michael! Can you please take a look at this?
Thank you!
Flags: needinfo?(mhughes)
|
||
Comment 2•8 months ago
|
||
Presumably we want to just neuter this by #ifdef for mingw builds; there's no reason to try to make the headers work in that environment, which exists (IIUC) for Tor and Tor alone. Like https://searchfox.org/mozilla-central/rev/762f24e00a9548d80ebba1b985c871ba6d9b829d/browser/app/winlauncher/ErrorHandler.cpp#221.
|
|
||
Comment 3•8 months ago
|
||
This was fixed by backout: https://hg.mozilla.org/integration/autoland/rev/a4442c3a0835e91a00944a5ac9ae6b5b03901d04
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
|
||
Updated•8 months ago
|
status-firefox121:
--- → unaffected
status-firefox122:
--- → unaffected
status-firefox123:
--- → fixed
status-firefox-esr115:
--- → unaffected
Target Milestone: --- → 123 Branch
|
||
Updated•8 months ago
|
Flags: needinfo?(mhughes)
| Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•