1872954 - [Protections Panel] Protections doorhanger has a blocked tracker milestones subviewbutton that is unlabeled

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect)

Description

[Anna Yeddi [:ayeddi]]

The Protections doorhanger UI includes a subview button with id protections-popup-milestones-content that does not provide an accessible name,

It appears to happen because this <toolbarbutton> XUL control is marked up with <description> as its child containing the on-screen text, while <label> does provide an expected output for the Accessibility API preserving its visual appearance at the same time.

When this bug is resolved, we need to remove the fail-if notation from the browser/base/content/test/protectionsUI/browser_protectionsUI_milestones.js test manifest.

Note: the following prefs are needed:

      // Hide protections cards so as not to trigger more async messaging
      // when landing on the page.
      ["browser.contentblocking.report.monitor.enabled", false],
      ["browser.contentblocking.report.lockwise.enabled", false],
      ["browser.contentblocking.report.proxy.enabled", false],
      ["browser.contentblocking.cfr-milestone.update-interval", 0],

A11y_checks output is the following:

Result	Path	Error	El ID	El tagName	El className	Stack trace
FAIL	browser/base/content/test/protectionsUI/browser_protectionsUI_milestones.js	Interactive elements must be labeled	protections-popup-milestones-content	toolbarbutton	subviewbutton	"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled:510
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:670
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtPoint:652
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouse:555
chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtCenter:740
chrome://mochitests/content/browser/browser/base/content/test/protectionsUI/browser_protectionsUI_milestones.js:doTest:78
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1872954 - [Protections Panel] Ensure blocker tracker milestones subviewbutton is labeled. r=#anti-tracking-reviewers

The Protections doorhanger UI includes a subview button with id protections-popup-milestones-content that does not provide an accessible name,

It appears to happen because this <toolbarbutton> XUL control is marked up with <description> as its child containing the on-screen text, while <label> does provide an expected output for the Accessibility API preserving its visual appearance at the same time.

Since this control would become labeled and would start passing a11y_checks, we are also removing the fail-if notation from the browser/base/content/test/protectionsUI/browser_protectionsUI_milestones.js test manifest.

Note: the following prefs are needed:

      // Hide protections cards so as not to trigger more async messaging
      // when landing on the page.
      ["browser.contentblocking.report.monitor.enabled", false],
      ["browser.contentblocking.report.lockwise.enabled", false],
      ["browser.contentblocking.report.proxy.enabled", false],
      ["browser.contentblocking.cfr-milestone.update-interval", 0],

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a5b0e04c06e
[Protections Panel] Ensure blocker tracker milestones subviewbutton is labeled. r=anti-tracking-reviewers,pbz

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3a5b0e04c06e