Closed
Bug 1873010
Opened 2 years ago
Closed 2 years ago
Remove chai-json-schema module from aboutwelcome/asrouter test code as it is not used
Categories
(Firefox :: Messaging System, task)
Firefox
Messaging System
Tracking
()
RESOLVED
FIXED
123 Branch
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
I just noticed that chai-json-schema is unused in the unit tests for aboutwelcome, asrouter and newtab, so we should remove it.
Although chai-json-schema gets set up, no tests attempt to call it. It looks like schema validation is now performed in the xpcshell-tests.
|
Assignee | |
Comment 1•2 years ago
|
||
I just realised, it is used in newtab code.
Component: New Tab Page → Messaging System
Summary: Remove chai-json-schema module from aboutwelcome/asrouter/newtab test code as it is not used → Remove chai-json-schema module from aboutwelcome/asrouter test code as it is not used
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b79dca57b9b1
Remove chai-json-schema module from aboutwelcome/asrouter/newtab test code as it is not used. r=aminomancer
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox123:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•