1873026 - ASRouter tests under browser/components/asrouter are not being run in CI

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1866802 moved a chunk of ASRouter out to browser/components/asrouter, and that included a number of tests. Unfortunately, those tests are fairly special, and use a try-runner.js script to run them in CI. I forgot to do that step when I did the move, so we haven't been running the ASRouter tests under browser/components/asrouter since the move.

This bug is to fix that.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Potential fix cooking on try: https://treeherder.mozilla.org/jobs?repo=try&revision=ee2249c79a69e93f02bb1368f2b58533791a9960

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1873026 - Hack the newtab try-runner.js script to also run about:asrouter tests and coverage. r?dmose!,ahal!

Comment 3

[Donal Meehan [:dmeehan]]

:mconley do you plan on landing this soon?
We are in the final week of beta for Fx122, we can take it there too once it's ready

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hi dmeehan,

I'm currently blocked on a review. I'll ping dmose to see if he can take a look at this soon.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2da4f909a45b
Hack the newtab try-runner.js script to also run about:asrouter tests and coverage. r=dmose,ahal

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2da4f909a45b

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Donal Meehan [:dmeehan]]

Since this is test-only change, it doesn't need an uplift request.
I will take it in a push today.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4ce422086c64