Closed
Bug 1873055
Opened 4 months ago
Closed 4 months ago
Fix missing awaits in test_engine_selector_environment.js and test_engine_selector_defaults.js
Categories
(Firefox :: Search, task, P1)
Firefox
Search
Tracking
()
RESOLVED
FIXED
123 Branch
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
I just noticed that we're not awaiting on the assertActualEnginesEqualsExpected calls in test_engine_selector_environment.js and test_engine_selector_defaults.js.
Although the tests generally pass, they're not checking the results properly, and the first one has a minor test failure due to using the wrong configuration in a test.
I'll put a patch up to fix these in a moment.
|
Assignee | |
Updated•4 months ago
|
Summary: Fix missing awaits in test_engine_selector_environment.js and test_engine_selector_defaults → Fix missing awaits in test_engine_selector_environment.js and test_engine_selector_defaults.js
|
|
Assignee | |
Comment 1•4 months ago
|
||
|
||
Updated•4 months ago
|
Attachment #9371117 -
Attachment description: Bug 1873055 - Fix missing awaits in test_engine_selector_environment.js and test_engine_selector_defaults.js. r?mcheang! → Bug 1873055 - Fix missing awaits in test_engine_selector_*.js in search tests. r?mcheang!
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4142f269312 Fix missing awaits in test_engine_selector_*.js in search tests. r=mcheang
|
||
Comment 3•4 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox123:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•