1873215 - Only show address capture doorhanger when the form contains certain fields

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P2)

Description

[Dimi Lee [:dimi]]

In the old design, as long as the address form submitted by users contains at least 3 fields, we consider the form "valid", and hence, the doorhanger is displayed after submission.
However,using a ‘number’ to determine whether to save might not be the best approach. It could lead to saving an address that doesn’t represent a valid address at all (e.g., Organization, Country, Phone). Additionally, it might result in showing the address capture doorhanger too frequently, particularly for users who do not want to save an address.

Additional Notes:
It seems that Chrome only displays the doorhanger when the form contains ALL of the following fields: Street Name, City, State, Postal Code, and Country.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1873215 - Display address capture prompt only for forms with all the required fields r=#credential-management-reviewers

Comment 2

[Dimi Lee [:dimi]]

Base on the the sheet, I think we can only capture an address when it contains "street-name", "address-level1", "address-level2", and "postal-code" .

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c918cd353494
Display address capture prompt only for forms with all the required fields r=credential-management-reviewers,joschmidt

Comment 4

[Cristina Horotan [:chorotan]]

Backed out changeset c918cd353494 (bug 1873215) for causing bc failures at browser_confirmation_popup.js

Backout: https://hg.mozilla.org/integration/autoland/rev/51a8c0fff9b8fad2bc66575077157e2534e60192

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c918cd353494009977248e41fc28313de2ec4356&selectedTaskRun=Tq4OXbYQTzilyYuP7pXR0A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=443314658&repo=autoland&lineNumber=42583

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4befc2acce9e
Display address capture prompt only for forms with all the required fields r=credential-management-reviewers,joschmidt

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4befc2acce9e

Comment 8

[Daniel Bodea [:danibodea]]

I'm attempting to verify bug 1870157, but I'm hitting a problem relating to how the address saving and address updating door hanger are displayed.
After investigating for the change using mozregression I stumbled upon this bug. Can you explain exactly what this bug changed?

After this change, when should the address saving door hanger appear? What about the address update door hanger?

Thank you!

Comment 9

[Daniel Bodea [:danibodea]]

I've received the necessary information. Please disregard my last comment. Thank you.