Closed Bug 1873267 Opened 1 year ago Closed 1 year ago

6.23 - 5.71% youtube fcp / youtube FirstVisualChange (Linux) regression on Mon December 25 2023

Categories

(Core :: Graphics: Canvas2D, defect)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox-esr115 --- unaffected
firefox121 --- unaffected
firefox122 --- unaffected
firefox123 --- affected

People

(Reporter: aesanu, Unassigned)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Perfherder has detected a browsertime performance regression from push fdd85a789550f85e20e7b7128f2b3316cbc76640. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new) Performance Profiles
6% youtube fcp linux1804-64-shippable-qr cold fission webrender 336.47 -> 357.42 Before/After
6% youtube FirstVisualChange linux1804-64-shippable-qr cold fission webrender 359.00 -> 379.52 Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(lsalzman)

Set release status flags based on info from the regressing bug 1871811

The locking added back in bug 1871811 is necessary to ensure correctness and proper functioning of canvas acceleration, which was the status quo before I removed the locking in the first place. So we are going to accept the regression. This was mitigated somewhat in subsequent enhancements that should reduce the impact of the locking.

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(lsalzman)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.