1873300 - stretch-grid-item-button-overflow.html shouldn't assert that scrollbars are impossible in buttons.

Status: RESOLVED FIXED

(Core :: Layout: Grid, task)

Description

[Daniel Holbert [:dholbert]]

The WPT stretch-grid-item-button-overflow.html (added here for bug 1871412) expects that overflow:scroll has no effect on buttons right now. But in fact Chrome and WebKit do add scrollbars onto overflow:scroll buttons right now.

Let's just remove the overflow:scroll part of the test for now, since it seems everyone is in agreement on the rest.
EDIT: we can also just add back overflow:scroll in the reference case; that's probably better.

Comment 1

[Daniel Holbert [:dholbert]]

I filed bug 1873301 to track the behavioral difference for button scrollability here.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1873300: Add overflow:scroll to buttons in a WPT reference case, to match styling in testcase. r?emilio

overflow:scroll doesn't add scrollbars to buttons in Firefox right now (per
bug 1873301) but it does add them in other browsers, so we need to include it
in the reference case (matching the testcase) so that the reference case is
valid/robust.

This patch doesn't change the reference case's rendering in Firefox, but it
seems to be sufficient to make this WPT pass in other browsers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b937c1028ead
Add overflow:scroll to buttons in a WPT reference case, to match styling in testcase. r=emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43909 for changes under testing/web-platform/tests

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b937c1028ead

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot