1873386 - Remove or fix references to non-scriptable interfaces from scriptable ones

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Tomislav Jovanovic :zombie]

Patch from bug 1872918 found a few non-scriptable interfaces referenced from scriptable ones:

interface nsIAsyncVerifyRedirectReadyCallback {}
interface nsICRLiteTimestamp {}
interface nsIWebAuthnRegisterArgs {}
interface nsIWebAuthnRegisterPromise {}
interface nsIWebAuthnSignArgs {}
interface nsIWebAuthnSignPromise {}

At least some look like they're meant to be [scriptable], but it's not 100% clear, so filing this as a followup to investigate and fix.

Comment 1

[Tomislav Jovanovic :zombie]

A more complete list:

interface nsIAsyncVerifyRedirectReadyCallback {}
interface nsICRLiteTimestamp {}
interface nsIInputAvailableCallback {}
interface nsIScriptElement {}
interface nsIThreadObserver {}
interface nsIUDPSocketSyncListener {}
interface nsIWebAuthnRegisterArgs {}
interface nsIWebAuthnRegisterPromise {}
interface nsIWebAuthnSignArgs {}
interface nsIWebAuthnSignPromise {}
interface nsIXPCScriptable {}

Comment 2

[Andrew McCreight (out of office until 8/21) [:mccr8]]

I guess this means a method that takes this kind of argument can't actually be called nor implemented by script. XPCWrappedNative::GatherProtoScriptable() is one use of one of these methods (nsIXPCScriptable is used by getScriptableHelper()), and it handles the method not working, so it looks like that is intentional.

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

We could require methods or attributes on scriptable interfaces that include non-scriptable arguments or return values be marked noscript maybe. I'm not sure how annoying that check would be to do.

Comment 4

[Nika Layzell [:nika] (ooo, ni? for response)]

(In reply to Andrew McCreight [:mccr8] from comment #3)

We could require methods or attributes on scriptable interfaces that include non-scriptable arguments or return values be marked noscript maybe. I'm not sure how annoying that check would be to do.

This is what I would like us to do.

Comment 5

[Tomislav Jovanovic :zombie]

Attachment: Bug 1873386 - Interfaces referenced from scriptable members need to be [scriptable] r?mccr8

Comment 6

[Tomislav Jovanovic :zombie]

Attachment: Bug 1873386 - Drop unused nsIStreamTransportService::InputAvailable and nsIInputAvailableCallback r?kershaw

Depends on D202104

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0102cdec251f
Interfaces referenced from scriptable members need to be [scriptable] r=necko-reviewers,jschanck,mccr8,valentin
https://hg.mozilla.org/integration/autoland/rev/a951e19e6158
Drop unused nsIStreamTransportService::InputAvailable and nsIInputAvailableCallback  r=kershaw,necko-reviewers

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0102cdec251f
https://hg.mozilla.org/mozilla-central/rev/a951e19e6158