1873408 - Full builds and artifact builds do different things when using wildcards in FINAL_TARGET_FILES

Status: NEW

(Firefox Build System :: General, defect, P3)

Description

[Mark Banner (:standard8)]

In bug 1870913 we are trying to ship a set of dumps for image files synced from remote settings.

I was trying to avoid the need to add every file to moz.build individually, so in services/settings/dumps/main/moz.build I tried adding:

FINAL_TARGET_FILES.defaults.settings.main["search-config-icons"] += [
    "search-config-icons/*",
]

For a full build, the files went into objdir/dist/bin/browser/defaults/settings/main/search-config-icons/search-config-icons/ as symlinks (not expected).

For an artifact build, the files went into objdir/dist/bin/browser/defaults/settings/main/search-config-icons/ as symlinks (expected).

Either these should behave in the same manner, or we should have an explicit disallow for using * in this case.

Comment 1

[Mark Banner (:standard8)]

I've just updated comment 0 to include ["search-config-icons"] on the first line of the definition, and corrected the path outputs.

Comment 2

[Mike Hommey [:glandium]]

Wildcards are not supposed to be supported. I'm surprised they're not rejected.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahochheiden, could you have a look please?

For more information, please visit BugBot documentation.