Closed Bug 1873414 Opened 5 months ago Closed 5 months ago

44.47 - 2.4% damp console.typing / damp custom.inspector.deeplynestedrule.refresh + 7 more (Linux, Windows) regression on Wed January 3 2024

Categories

(Core :: Panning and Zooming, defect)

Product:
Core
Component:
Panning and Zooming
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
123 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox121 --- unaffected
firefox122 --- unaffected
firefox123 --- fixed

People

(Reporter: nchevobbe, Assigned: tnikkel)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Attachments

(1 file)

Bug 1873414. In MaybeCreateDisplayPortInFirstScrollFrameEncountered descend into leaf frames because they can contain anonymous content. r?botond,#layout-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Perfherder has detected a devtools performance regression from push 9ea90dc23395fc3e2d9d2bd18598cc49434eeff1. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
44% damp console.typing linux1804-64-shippable-qr e10s fission stylo webrender-sw 408.81 -> 590.60
41% damp console.typing linux1804-64-shippable-qr e10s fission stylo webrender 421.14 -> 595.40
7% damp console.typing windows10-64-shippable-qr e10s fission stylo webrender-sw 376.48 -> 404.18
7% damp console.typing windows10-64-shippable-qr e10s fission stylo webrender 375.80 -> 400.21
6% damp custom.netmonitor.requestsFinished.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 2,307.28 -> 2,450.47
5% damp custom.netmonitor.requestsFinished.DAMP windows10-64-shippable-qr e10s fission stylo webrender 2,306.01 -> 2,430.50
5% damp custom.netmonitor.requestsFinished.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 2,844.16 -> 2,984.38
5% damp custom.netmonitor.requestsFinished.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 2,793.09 -> 2,927.53
5% damp custom.inspector.expandall.balanced windows10-64-shippable-qr e10s fission stylo webrender-sw 511.88 -> 535.22
5% damp custom.netmonitor.reload.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 346.95 -> 362.70
... ... ... ... ...
4% damp custom.inspector.expandall.balanced windows10-64-shippable-qr e10s fission stylo webrender 520.28 -> 540.87
3% damp custom.jsdebugger.stepOver.DAMP windows10-64-shippable-qr e10s fission stylo webrender 433.99 -> 445.26
2% damp custom.inspector.deeplynestedrule.refresh windows10-64-shippable-qr e10s fission stylo webrender-sw 83.22 -> 85.22
2% damp custom.jsdebugger.stepOver.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 431.01 -> 441.19
2% damp custom.inspector.deeplynestedrule.refresh windows10-64-shippable-qr e10s fission stylo webrender 72.46 -> 74.11

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Set release status flags based on info from the regressing bug 1872564

:tnikkel, since you are the author of the regressor, bug 1872564, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

status-firefox121: --- → unaffected
status-firefox122: --- → unaffected
status-firefox123: --- → affected
status-firefox-esr115: --- → unaffected
Flags: needinfo?(tnikkel)

Leaf frames can contain anonymous content, for example text control frames, and we were activating them before and not activating them caused a perf regression in some tests, so restore that behaviour.

This illustrates that some of the performance improvement of using the leaf check came from not descending into some subtrees and changes the perf balance of the patch from bug 1872564. I re-did the measurements with this new constraint and now the IsScrollContainer check is faster, so I switched to using that.

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Flags: needinfo?(tnikkel)
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0a524f0a008
In MaybeCreateDisplayPortInFirstScrollFrameEncountered descend into leaf frames because they can contain anonymous content. r=layout-reviewers,emilio

https://hg.mozilla.org/mozilla-central/rev/f0a524f0a008

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox123: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
Duplicate of this bug: 1873863

(In reply to Pulsebot from comment #3)

Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0a524f0a008
In MaybeCreateDisplayPortInFirstScrollFrameEncountered descend into leaf
frames because they can contain anonymous content. r=layout-reviewers,emilio

== Change summary for alert #40909 (as of Tue, 09 Jan 2024 07:20:51 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new) Performance Profiles
6% fandom loadtime windows10-64-shippable-qr bytecode-cached cold fission webrender 1,091.54 -> 1,024.16 Before/After
6% instagram largestContentfulPaint windows10-64-shippable-qr cold fission webrender 1,372.48 -> 1,292.90 Before/After
5% yahoo-mail loadtime macosx1015-64-shippable-qr fission warm webrender 360.37 -> 342.43 Before/After
5% instagram LastVisualChange windows10-64-shippable-qr cold fission webrender 1,415.53 -> 1,350.09 Before/After
4% yahoo-mail loadtime linux1804-64-shippable-qr fission warm webrender 479.43 -> 460.98 Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40909

Regressions: 1875785
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: