187342 - DOM Ref window.innerWidth change

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Garrett Smith]

Window.innerWidth

type: readonly
value: number

description:
the width of the window including the scrollbar but excluding any other chrome
such as window borders, sidebars, et c.

Comment 1

[Daniel Wang]

reporter (Garrett Smith), you can use the "Edit this Page" link at the bottom of the
page to make a patch.

Index: mozilla-org/html/docs/dom/domref/dom_window_ref28.html
===================================================================
RCS file: /cvsroot/mozilla-org/html/docs/dom/domref/dom_window_ref28.html,v
retrieving revision 1.33
diff -u -r1.33 dom_window_ref28.html
--- mozilla-org/html/docs/dom/domref/dom_window_ref28.html	11 Dec 2002
21:53:00 -0000	1.33
+++ mozilla-org/html/docs/dom/domref/dom_window_ref28.html	1 Jan 2003 22:19:00 -0000
@@ -36,7 +36,8 @@
   <a name="1017395"> </a>window.innerWidth
 </h1><hr>
 <p class="Body">
-  <a name="1008000"> </a>Gets/sets the height of the content area of the
browser window.
+  <a name="1008000"> </a>Gets the height of the content area of the browser window,
+  including the scrollbar but excluding any other chrome such as window
borders, sidebars, status bar, etc.
 </p>
 <h4 class="Heading3">
   <a name="1008001"> </a>Syntax
@@ -78,6 +79,7 @@
   <a name="1008012"> </a>Notes
 </h4>
 <p class="Body">
+  Read only.
   <a name="1008019"> </a>See also <a
href="dom_window_ref27.html#1017378"><b>window.innerHeight</b></a>, <a
href="dom_window_ref78.html#1019369"><b>window.outerHeight</b></a>.
 </p>
 <h4 class="Heading3">

Comment 2

[Garrett Smith]

I don't have a cvs acct. 

Comment 3

[Garrett Smith]

.

Comment 4

[Gérard Talbot]

This bug obviously never was fixed... unless I'm missing something. Right now,
the file says 
"window.innerWidth
Gets the *_height_* of the content area of the browser window."
I wonder why the formal description of type and value were not added. Also, it
is important to mention that such property includes the vertical scrollbar if
present, if rendered.
Finally, winWidth is not a parameter; winWidth is just a variable storing a value.

REOPENING

Comment 5

[Gérard Talbot]

The file is written in HTML 3.2 and has 36 errors; when validating with HTML
4.01 strict as requested by 
mozilla.org Documentation Style Guide
http://www.mozilla.org/contribute/writing/guidelines#validation
the document shows 12 errors. The document also uses other no-no's: table
design, <font>, inline style declarations, etc..

-> me

target: before december 1st 2004

Comment 6

[Gérard Talbot]

Attachment: 1st patch (checked in)

Initial patch
- removed <font> and unknown classes
- added the info requested by original reporter
- implemented HTML 4.01 strict
- etc..

more to come

Comment 7

[Gérard Talbot]

Attachment: 2nd patch (checked in)

Now, the page is valid HTML 4.01 strict.

Comment 8

[Gérard Talbot]

Attachment: 3rd patch (checked in)

Added interactive example

Comment 9

[Gérard Talbot]

Attachment: 4th patch (checked in)

Made the initResizeFunc and stopResizeFunc functions to work under Opera 7.x

Comment 10

[Gérard Talbot]

Attachment: 5th patch (checked in)

Added intra-site navigation <link>s (previous, next, Table of contents, Index)
and bookmarks to innerHeight, outerWidth, outerHeight.

Comment 11

[Alex Vincent [:WeirdAl]]

I'm discussing this with du in #documentation.  fantasai, per our last
discussion, I don't think either of us knows if DOMRef was frozen or not.  If it
was, we may be forced to back this stuff out for reasons legal or otherwise. 
Can you think of anyone else who needs to be aware of this (mitchell, oeschger?)

Comment 12

[Gérard Talbot]

I have asked to review the applied patches. 

As far as I'm concerned, what remains to be done in the document
- check wording of expressions
- establish a better style of the document linked to the formating of sections
and one which could be re-used over for other properties, methods in DOM Ref
- remove old coding manners and use rules and/or classes defined in
cavendish/content.css
- reformat the tables of intra-DOMref-site navigation

Comment 13

[Doron Rosenberg (IBM)]

In theory DOM Ref is frozen pending XMLization, but XForms work has stopped me
finishing that.  Note that cleaning up HTML will be short term as the system
will move to XSLT and data will be in XML.

You should get review before checking in though.

Comment 14

[Gérard Talbot]

We can reopen later if needed, if necessary. Thanks Doron for your assistance
here. :)

Comment 15

[Gérard Talbot]

I added an image to the file to illustrate physical dimensions of
WindowObjectReference.innerWidth.

Also remove the "s" from summary which was making the searching for this bug
much difficult.

Comment 16

[Gérard Talbot]

Attachment: 6th patch (checked in)

Added an image showing physical borderlines of innerWidth