1873422 - Pictures in zh.m.wikipedia.ecnu.cf don't display

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Tom25519]

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:121.0) Gecko/121.0 Firefox/121.0

Steps to reproduce:

Open a page which have pictures in https://zh.m.wikipedia.ecnu.cf/ (a Wikipedia mirror website), for example, https://zh.m.wikipedia.ecnu.cf/wiki/%E8%87%AD%E6%B0%A7%E5%B1%82

Actual results:

Picture don't display, but Edge not.

Expected results:

This bug shouldn't appear.

Comment 1

[Tom25519]

This bug happened on 121.0.1, 122.0b6 and latest nightly (123.0a1 (Build #2015996322), e58472c627+ GV: 123.0a1-20240107090723 AS: 123.20240106050300 2024-01-08T04:08:13.735790560).

Comment 2

[jackyzy823]

Detailedly:
https://upload.wikimedia.ecnu.cf/wikipedia/commons/thumb/e/ea/Couches_de_l'atmosphere.png/300px-Couches_de_l'atmosphere.png

It couldn't displayed either on Firefox Desktop (tested under Linux/121 and Windows/118)

---

I think it should in Core->Graphics: ImageLib.

Comment 3

[jackyzy823]

Attachment: original_file.png

Comment 4

[Timothy Nikkel (:tnikkel)]

Debug output
[Child 27174: TaskController #5]: W/PNGDecoder libpng warning: tRNS: duplicate
[Child 27174: TaskController #7]: W/PNGDecoder libpng warning: tRNS: duplicate
[Child 27174: TaskController #2]: W/PNGDecoder libpng warning: tEXt: CRC error
[Child 27174: TaskController #2]: E/PNGDecoder libpng error: [00][00][00][25]: invalid chunk type

Might be the same issue as bug 1693190

Comment 5

[Erich Gubler [:ErichDonGubler]]

Given the similarity of impact and symptoms to that of bug 1693190, I will triage this bug's severity to be the same.

Comment 6

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1873422. Ignore "invalid chunk type" errors in pngs if we have enough data to display something when encountered. r?aosmond

GetFrameCount() > 0 means that we've started a frame, but not necessarily finished it.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:tnikkel, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 8

[Timothy Nikkel (:tnikkel)]

Soft freeze.

Comment 9

[Timothy Nikkel (:tnikkel)]

This seems to be a spec issue discussing this https://github.com/w3c/PNG-spec/issues/320

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/553d0d707d9d
Ignore "invalid chunk type" errors in pngs if we have enough data to display something when encountered. r=aosmond

Comment 11

[chris]

This will help with the "Invalid images" part of https://philip.html5.org/tests/apng/tests.html

(I added the valid APNG tests from there into WPT https://github.com/web-platform-tests/wpt/pull/42893 and am working on porting the invalid APNG tests too)

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/553d0d707d9d