Closed Bug 1873422 Opened 10 months ago Closed 8 months ago

Pictures in zh.m.wikipedia.ecnu.cf don't display

Categories

(Core :: Graphics: ImageLib, defect)

All
Android
defect

Tracking

()

RESOLVED FIXED
125 Branch
Tracking Status
firefox125 --- fixed

People

(Reporter: Tom25519, Assigned: tnikkel)

References

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:121.0) Gecko/121.0 Firefox/121.0

Steps to reproduce:

Open a page which have pictures in https://zh.m.wikipedia.ecnu.cf/ (a Wikipedia mirror website), for example, https://zh.m.wikipedia.ecnu.cf/wiki/%E8%87%AD%E6%B0%A7%E5%B1%82

Actual results:

Picture don't display, but Edge not.

Expected results:

This bug shouldn't appear.

This bug happened on 121.0.1, 122.0b6 and latest nightly (123.0a1 (Build #2015996322), e58472c627+ GV: 123.0a1-20240107090723 AS: 123.20240106050300 2024-01-08T04:08:13.735790560).

Detailedly:
https://upload.wikimedia.ecnu.cf/wikipedia/commons/thumb/e/ea/Couches_de_l'atmosphere.png/300px-Couches_de_l'atmosphere.png

It couldn't displayed either on Firefox Desktop (tested under Linux/121 and Windows/118)


I think it should in Core->Graphics: ImageLib.

Component: Browser Engine → Graphics: ImageLib
Product: Fenix → Core
Attached image original_file.png

Debug output
[Child 27174: TaskController #5]: W/PNGDecoder libpng warning: tRNS: duplicate
[Child 27174: TaskController #7]: W/PNGDecoder libpng warning: tRNS: duplicate
[Child 27174: TaskController #2]: W/PNGDecoder libpng warning: tEXt: CRC error
[Child 27174: TaskController #2]: E/PNGDecoder libpng error: [00][00][00][25]: invalid chunk type

Might be the same issue as bug 1693190

See Also: → 1693190
Severity: -- → S3

Given the similarity of impact and symptoms to that of bug 1693190, I will triage this bug's severity to be the same.

GetFrameCount() > 0 means that we've started a frame, but not necessarily finished it.

Assignee: nobody → tnikkel
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:tnikkel, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(tnikkel)
Flags: needinfo?(aosmond)

Soft freeze.

Flags: needinfo?(tnikkel)
Flags: needinfo?(aosmond)

This seems to be a spec issue discussing this https://github.com/w3c/PNG-spec/issues/320

Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/553d0d707d9d Ignore "invalid chunk type" errors in pngs if we have enough data to display something when encountered. r=aosmond

This will help with the "Invalid images" part of https://philip.html5.org/tests/apng/tests.html

(I added the valid APNG tests from there into WPT https://github.com/web-platform-tests/wpt/pull/42893 and am working on porting the invalid APNG tests too)

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: