1873464 - For search related configurations, only validate additional properties on nightly builds

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

For our various search configurations that we validate against the schemas, we have decided to only validate additional properties on nightly builds.

The reasons for this are:

• it is generally acceptable that we add new properties to the remote settings collections - older versions will ignore those properties.
• it will avoid us needing to uplift schema additions to older branches, just to get tests passing.
• the older branches will keep the schema that matches the collection when it was shipped, which will help with answering questions like "does this version support this property?".

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1873464 - For search related configurations, only validate additional properties on nightly builds. r?#search-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6a30b38e553
For search related configurations, only validate additional properties on nightly builds. r=search-reviewers,mcheang

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f6a30b38e553

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1873464 - For search related configurations, only validate additional properties on nightly builds.

Original Revision: https://phabricator.services.mozilla.com/D197920

Comment 5

[Donal Meehan [:dmeehan]]

:standard8 can you fill in the uplift request form for review?
You can add it in the phab revision by selecting the Change Uplift Request Form action

Comment 6

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• Risk associated with taking this patch: Low
• String changes made/needed: None
• Explanation of risk level: test-only change
• Fix verified in Nightly: yes
• Steps to reproduce for manual QE testing: N/A
• Needs manual QE test: no
• Is Android affected?: no
• User impact if declined: None, test-only change which will reduce the need for non-production files uplift when landing remote settings dumps

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3415efad3e40

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 1873464 - For search related configurations, only validate additional properties on nightly builds.

Original Revision: https://phabricator.services.mozilla.com/D197920

Comment 9

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: no
• String changes made/needed: None
• User impact if declined: None, test-only change which will reduce the need for non-production files uplift when landing remote settings dumps
• Code covered by automated testing: yes
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Test-only change
• Fix verified in Nightly: yes
• Is Android affected?: no

Comment 10

[Mark Banner (:standard8)]

(In reply to Donal Meehan [:dmeehan] from comment #5)

:standard8 can you fill in the uplift request form for review?

Sorry, I'd been having some problems with uplift (now fixed) and then was in meetings, so the request was delayed.

Comment 11

[Mark Banner (:standard8)]

Attachment: Bug 1873464 - For search related configurations, only validate additional properties on nightly builds.

Original Revision: https://phabricator.services.mozilla.com/D197920

Comment 12

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: Low
• Steps to reproduce for manual QE testing: N/A
• Explanation of risk level: Test-only change
• String changes made/needed: None
• User impact if declined: None, test-only change which will reduce the need for non-production files uplift when landing remote settings dumps
• Needs manual QE test: no
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Is Android affected?: no

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/496a204850ef

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/0c131dd840f2

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/b0f0ec53fe3f