1873473 - Update Documentation in Table Border Collapsing Code

Status: RESOLVED FIXED

(Core :: Layout: Tables, enhancement)

Description

[David Shin[:dshin]]

Part of bug 1871609 investigation.
Some references it makes are old, and the code handles a lot of states that puts a lot of mental load - Will be bringing documentations up-to-date (And hopefully help whoever else looks at it).

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1873473: Part 1 - Refactor `lastBStartBorder` in nsTableFrame::CalcBCBorders to be `Maybe<T>` r=#layout-reviewers

This is only used to calculate the block-start border of the overall table,
not and is unused after. Use Maybe<> to reflect it as such.

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1873473: Part 2 - Move variables in `CalcBCBorders` to be more scope-specific where possible. r=#layout-reviewers

Depends on D197930

Comment 3

[David Shin[:dshin]]

Attachment: Bug 1873473: Part 3 - Rename variables using physical corners in `CalcBCBorders` to logical corners. r=#layout-reviewers

Depends on D197931

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1873473: Part 4 - Update documentation in `CalcBCBorders`. r=#layout-reviewers

Depends on D197932

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9779b53e1f5
Part 1 - Refactor `lastBStartBorder` in nsTableFrame::CalcBCBorders to be `Maybe<T>` r=TYLin
https://hg.mozilla.org/integration/autoland/rev/a80dff0e258f
Part 2 - Move variables in `CalcBCBorders` to be more scope-specific where possible. r=layout-reviewers,TYLin
https://hg.mozilla.org/integration/autoland/rev/43654d479b94
Part 3 - Rename variables using physical corners in `CalcBCBorders` to logical corners. r=layout-reviewers,TYLin
https://hg.mozilla.org/integration/autoland/rev/fd9acb39042b
Part 4 - Update documentation in `CalcBCBorders`. r=TYLin

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a9779b53e1f5
https://hg.mozilla.org/mozilla-central/rev/a80dff0e258f
https://hg.mozilla.org/mozilla-central/rev/43654d479b94
https://hg.mozilla.org/mozilla-central/rev/fd9acb39042b