Closed
Bug 1873657
Opened 2 years ago
Closed 8 months ago
Stop using the parser worker for determining JSX and typescript jsx
Categories
(DevTools :: Debugger, enhancement)
DevTools
Debugger
Tracking
(firefox135 fixed)
RESOLVED
FIXED
135 Branch
| Tracking | Status | |
|---|---|---|
| firefox135 | --- | fixed |
People
(Reporter: bomsy, Assigned: bomsy)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently the parser worker gathers JSX and typescript details about a source file https://searchfox.org/mozilla-central/rev/7fc94186f1a759790c56e41a90ab350d78dbda30/devtools/client/debugger/src/workers/parser/getSymbols.js#52-54,56-58,106-107,376-377
These information is used to determine the editor modes.
https://searchfox.org/mozilla-central/rev/7fc94186f1a759790c56e41a90ab350d78dbda30/devtools/client/debugger/src/utils/editor/source-documents.js#159-169
With the impact of the parser worker on performance, we could probably determine jsx / typescript editor modes based on the file extensions and avoid using the worker for these.
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D197907
|
||
Updated•2 years ago
|
Assignee: nobody → hmanilla
Attachment #9371744 -
Attachment description: WIP: Bug 1873657 - [devtools] Stop using the parser worker for determining JSX and typescript jsx → Bug 1873657 - [devtools] Stop using the parser worker for determining JSX and typescript jsx r=#devtools-reviewers
Status: NEW → ASSIGNED
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdef9da724db
[devtools] Stop using the parser worker for determining JSX and typescript jsx r=devtools-reviewers,ochameau
|
||
Comment 3•8 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox135:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•