1873743 - Centralize the architecture of the machine learning engine

Status: RESOLVED FIXED

(Firefox :: Translations, task, P2)

Description

[Greg Tatum [:gregtatum]]

As others begin to experiment with ML models, we should centralize on a shared engine creator. Similar to what Translations did with a single process model in Bug 1815339, we can extend this for others to use.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1873743 - Stub out the toolkit/components/ml files; r?#translations-reviewers!

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1873743 - Stub out enough of remote settings to download; r?#translations-reviewers!

Depends on D198071

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1873743 - Implement the MLEngine actor; r?#translations-reviewers!

Depends on D198072

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1873743 - Move the engine into a worker; r?#translations-reviewers!

Depends on D198073

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1873743 - Centralize the engine process logic; r?#translations-reviewers!

Depends on D198074

Comment 6

[Greg Tatum [:gregtatum]]

Attachment: Bug 1873743 - Add usage documentation; r?#translations-reviewers

Depends on D198075

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af470fddc2d4
Stub out the toolkit/components/ml files; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/70ffe08ff7cb
Stub out enough of remote settings to download; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/59d5a7bff4fa
Implement the MLEngine actor; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/114ea06972d3
Move the engine into a worker; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/a695e04c3d54
Centralize the engine process logic; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/bb96b326fd83
Add usage documentation; r=translations-reviewers,nordzilla

Comment 8

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_translations_panel_auto_translate_error_view.js, browser_about_translations_translations.js and assertion failure on ServoUtils.h

Backout link

Push with failures

Failure log 1 // Failure log 2 // Failure log 3

Comment 9

[Greg Tatum [:gregtatum]]

I still need to investigate this.

Comment 10

[Greg Tatum [:gregtatum]]

I rebased and found the bug. It was yet another thing that would have been caught by having a type system in JS. I'll land after a clean try run.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8d384c0321a
Stub out the toolkit/components/ml files; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/2e9f3759da5a
Stub out enough of remote settings to download; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/4f9b7686df52
Implement the MLEngine actor; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/6baf7a096eba
Move the engine into a worker; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/1f54d4417ebd
Centralize the engine process logic; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/748e969e9203
Add usage documentation; r=translations-reviewers,nordzilla

Comment 12

[Sandor Molnar[:smolnar]]

Backed out for causing assertion failures @ xpcom/threads/nsThreadManager.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/fb3764ce8b756fcf6621245faed934f7ce159008

Push with failures

Failure log -> Assertion failure: NS_IsMainThread() (Wrong thread!), at /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33facf395f0c
Stub out the toolkit/components/ml files; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/aeca457f63cb
Stub out enough of remote settings to download; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/ec1ae112bf2e
Implement the MLEngine actor; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/bd4763ff6a76
Move the engine into a worker; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/539800835dd1
Centralize the engine process logic; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/cb212fa2b422
Add usage documentation; r=translations-reviewers,nordzilla

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/33facf395f0c
https://hg.mozilla.org/mozilla-central/rev/aeca457f63cb
https://hg.mozilla.org/mozilla-central/rev/ec1ae112bf2e
https://hg.mozilla.org/mozilla-central/rev/bd4763ff6a76
https://hg.mozilla.org/mozilla-central/rev/539800835dd1
https://hg.mozilla.org/mozilla-central/rev/cb212fa2b422