1873778 - malformed sym files cause eliot to send two sentry events

Status: RESOLVED FIXED

(Eliot :: General, defect, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

When Eliot goes to parse a sym file that's malformed--say because it was missing an INLINE_ORIGIN symbol (bug #1794095)--it causes Sentry to send two events.

One event gets sent from this LOGGER.exception in symbolicate_resource.parse_sym_file:

https://github.com/mozilla-services/eliot/blob/82bcae05b11400c72c4299709690357788003bc1/eliot/symbolicate_resource.py#L279-L284

That one is probably fine and we should leave that as is.

The other event is sent from this LOGGER.exception in libsymbolic.parse_sym_file:

https://github.com/mozilla-services/eliot/blob/82bcae05b11400c72c4299709690357788003bc1/eliot/libsymbolic.py#L140-L145

That one is from a library module. I claim it shouldn't be logging exceptions and instead it should raise an exception and let the caller decide what to do about it (log an exception, emit a metric, etc).

Comment 1

[Daniel Thorn [:relud]]

Attachment: [mozilla-services/eliot] bug-1873778: remove duplicate exception log for malformed sym files (#125)

Comment 2

[Daniel Thorn [:relud]]

relud merged PR [mozilla-services/eliot]: bug-1873778: remove duplicate exception log for malformed sym files (#125) in 94a4d7c.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was deployed to prod in bug #1886236. Marking as FIXED.