1873862 - The pixels size counter is not visible enough on the selected screenshot region

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P3)

Description

[Simona Badau, Desktop QA]

Attachment: Screenshot with the issue

Found in

• Nightly 123.0a1

Affected versions

• Nightly 123.0a1

Tested platforms

• Affected platforms: macOS 13, Ubuntu 22.04 and Windows 10 x64

Preconditions

• 'screenshots.browser.component.enabled' is set to true in about:config

Steps to reproduce

1. Navigate to https://en.wikipedia.org/wiki/Firefox
2. Enable Screenshots by hitting the Cmd/Ctrl+Shift+S keys.
3. Select a region by mouse dragging over the screenshots overlay.
4. Observe the screenshot size counter.

Expected result

• The screenshot size counter should be clearly visible.

Actual result

• The screenshot size counter is not visible enough, especially when Firefox has a Light theme set. Please see the attached screenshot for more details.

Regression range

• This is not a regression, it's reproducible only when enabling the component version of Screenshots.

Additional notes

• On darker themes the issue is not as evident.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sbadau, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Sam Foster [:sfoster] (he/him)]

Thanks for spotting this. I think a drop shadow or border would help here. I don't think we need to block on it however.

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1873862 - Add border to screenshots selection size text. r=sfoster,kcochrane

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71d83c41d55f
Add border to screenshots selection size text. r=sfoster,kcochrane,desktop-theme-reviewers,jules

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/71d83c41d55f

Comment 6

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 127.0a1 on macOS 13, Ubuntu 22.04 and Windows 10.