1873916 - [wdspec] Recommended preferences for Remote Agent are no longer set for WebDriver classic and BiDi tests

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As I've noticed while working on bug 1857961 all the recommended preferences for the Remote Agent are no longer set for wdspec tests. That means that there are a couple of preferences, which never get set and can cause more or less test failures. The following preferences are affected:

browser.contentblocking.features.standard
browser.contentblocking.introCount
browser.search.update
browser.tabs.closeWindowWithLastTab
browser.tabs.warnOnClose
browser.tabs.warnOnCloseOtherTabs
browser.tabs.warnOnOpen
browser.usedOnWindows10.introURL
browser.zoom.siteSpecific
datareporting.policy.dataSubmissionPolicyAccepted
dom.navigation.locationChangeRateLimit.count
dom.screenorientation.allow-lock
network.connectivity-service.enabled
network.cookie.cookieBehavior
privacy.trackingprotection.enabled
security.fileuri.strict_origin_policy
signon.autofillForms
widget.windows.window_occlusion_tracking.enabled

Whether we can add remote.prefs.recommended=true to the general user.js file for wpt tests or we have to create an additional file specifically for wdspec. Personally I would prefer to have the latter solution.

James, I assume that this is a regression from moving the profile generation from geckodriver to wptrunner from quite some time ago. Interesting that we never noticed this problem.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Probably we need a different user.js file given that normal wpt tests will run based on Marionette and hereby we have different expectations.

Comment 2

[James Graham [:jgraham]]

If it's just a single pref we can also set it directly in wptrunner, which is easier, but perhaps less obvious to future readers.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1873916 - [wptrunner] Use recommended preferences for Remote Agent when running wdspec tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/855a9385b41c
[wptrunner] Use recommended preferences for Remote Agent when running wdspec tests. r=webdriver-reviewers,jgraham,jdescottes

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43964 for changes under testing/web-platform/tests

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/855a9385b41c

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot