Closed
Bug 1873969
Opened 1 year ago
Closed 1 year ago
Convert HighlightsFeed.jsm into an ESM
Categories
(Firefox :: New Tab Page, task, P1)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
124 Branch
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Whiteboard: [esmification-timeline] )
Attachments
(2 files)
HighlightsFeed uses the injection system in its unit test which is incompatible with ESMs. This means that prior to converting the module, we must convert HighlightsFeed.test.js into an xpcshell test. This bug covers doing both things.
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → mconley
Whiteboard: [esmification-timeline]
|
||
Updated•1 year ago
|
Severity: -- → N/A
Priority: -- → P1
|
|
Assignee | |
Comment 1•1 year ago
|
||
Depends on D197972
|
|
Assignee | |
Comment 2•1 year ago
|
||
Depends on D198322
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4752fe84832
Convert HighlightsFeed.test.js to an xpcshell test. r=thecount
https://hg.mozilla.org/integration/autoland/rev/82dfbdd770bc
Convert HighlightsFeed.jsm to an ESM. r=thecount
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d4752fe84832
https://hg.mozilla.org/mozilla-central/rev/82dfbdd770bc
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox124:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•