Make deprecated system color InfoBackground same as css-color-4 system color Canvas.
Categories
(Core :: CSS Parsing and Computation, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: ayeddi, Assigned: ayeddi, Mentored)
References
()
Details
Attachments
(3 files)
css-color-blink.png
Expected results:
As per css-color-4 Appendix A: Deprecated CSS System Colors.
WPT test affected: https://searchfox.org/mozilla-central/source/testing/web-platform/tests/css/css-color/deprecated-sameas-011.html
|
Assignee | |
Comment 1•6 months ago
|
||
Map InfoBackground to the Canvas to conform with css-color-4 Appendix A: Deprecated CSS System Colors and update expected WPT and dom/canvas test results.
Depends on D198210
|
||
Updated•6 months ago
|
|
||
Comment 2•6 months ago
|
||
FWIW, if you find it handy you can visually view and group colors at https://arkenfox.github.io/TZP/tests/csscolors.html - here's chrome
I don't have the full picture/knowledge, but reducing these in FF (pic to follow, can't seem to add two pics to a post) seems like a good idea
I think it would be nice, if possible now, to set all these the same if not for all users, but at least for RFP (you can vary per platform if need be) so it's deterministic - IIUIC we only protect -moz colors and a couple of others, and understand that we can't protect all of them
|
|
||
Comment 3•6 months ago
|
||
and here's Firefox nightly 123 windows 11, RFP is off btw - I zoomed out to shrink it, feel free to visit the actual url :)
|
|
Assignee | |
Comment 4•6 months ago
|
||
(In reply to Simon Mainey from comment #2)
Created attachment 9372148 [details]
css-color-blink.pngFWIW, if you find it handy you can visually view and group colors at https://arkenfox.github.io/TZP/tests/csscolors.html - here's chrome
I don't have the full picture/knowledge, but reducing these in FF (pic to follow, can't seem to add two pics to a post) seems like a good idea
I think it would be nice, if possible now, to set all these the same if not for all users, but at least for RFP (you can vary per platform if need be) so it's deterministic - IIUIC we only protect -moz colors and a couple of others, and understand that we can't protect all of them
Thank you for the investigation, Simon!
Per the Chromes screenshot, it looks like this is what the stack of patches that I’m working on would look like for Firefox, when landed: they did remapped the deprecated colors to the (less crowded set of) current CSS Color Level 4 system colors. The changes are just tracked in separate bugs grouped by needed remapping value. I’m excited to re-check the URL after the stack of patches is landed to confirm the reduction too!
|
|
Assignee | |
Updated•6 months ago
|
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21fe488812eb Make deprecated system color InfoBackground same as css-color-4 system color Canvas. r=morgan,emilio
|
||
Comment 6•5 months ago
|
||
| bugherder | ||
Description
•