1874074 - Pocket suggestions are fetched when the Amo provider is specified, regardless of whether Pocket was specified

Status: RESOLVED DUPLICATE of bug 1876630

(Application Services :: Suggest, defect, P3)

Description

[Drew Willcoxon :adw]

query() seems to fetch Pocket suggestions as long as the Amo provider is specified, even when Pocket is not specified. AFAICT it might be due to the second SELECT in the UNION here, which does not check the list of passed-in providers like the first SELECT does, but I'm not sure and haven't debugged it. I only found this today while working on the test for the desktop bug 1874072.

I didn't find that Amo suggestions are fetched when Pocket is specified, but that may be due only to my specific test case because it looks like that might be possible too?

Comment 1

[Drew Willcoxon :adw]

Also I'm testing with the suggest in m-c, but it doesn't look like this particular code has changed.

Comment 2

[Lina Butler (ex-Mozilla)]

Thanks Drew! This will be fixed by the fetch_suggestions() refactor that Tif is doing in bug 1876630—the UNION ALL and the complicated query will go away, in favor of querying the providers separately, then combining and sorting the results in Rust after.