1874123 - [US][costco.com] The City and State/Region fields are not captured in the address save doorhanger

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, task, P3)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: 2024-01-04_17h56_08.mp4

Found in

• Fx 123.0a1

Affected versions

• Fx 123.0a1

Affected platforms

• Windows/macOS

Preconditions

• Install the Firefox en-US build
• Set browser.search.region to US in about:config
• Flip following prefs in about:config:
  * extensions.formautofill.addresses.capture.v2.enabled = true
  * extensions.formautofill.addresses.supported = on
  * extensions.formautofill.heuristics.captureOnFormRemoval = true
  * extensions.formautofill.heuristics.captureOnPageNavigation = true
• Use US VPN to test

Steps to reproduce

1. Go to https://www.costco.com/
2. Add an item to Cart and navigate to the checkout page
3. Fill in the Address Form, submit the form and save the address through the Address Capture doorhanger

Expected result

• The City and State/Region fields should be captured in the save doorhanger and stored accordingly.

Actual result

• The City and State/Region fields are autofilled automatically based on the ZIP code and they are not captured in the save doorhanger.

Additional notes

• Fathom sample

Comment 1

[Janika Neuberger [:janika]]

When first identifying field details after a focus event on one of the form elements, we ignore invisible <input> elements see getFormInfo in FormAutofillHeuristics. After the street address is filled, the city and state elements become visible. Before we detected the state <select> element but we ignored the city <input> element. Now the problem is that in updateFormIfNeeded in FormAutofillHandler we only update the form if the amount of form elements have changed since we last identified the field details. For the costco.com address form the amount of elements doesn't change, only the visibility states of some of the form elements change. Therefore when submitting the form we still haven't identified the city <input> element. The address doorhanger is not shown, because the address-level2 is a required fields.

We should extend our heuristics to consider the visibility state of possibly "fillable" fields.

The city <input> element even has the autocomplete attribute set to address-level2.

Comment 3

[Alin Ilea, Desktop Test Engineering]

Cannot verify this one since the capture doorhanger is no longer displayed. It is also NOT displayed by flipping the dynamic form prefs to false, so not a regression caused by 1837161. It is still not displayed by setting the extensions.formautofill.addresses.capture.requiredFields to empty.

Comment 4

[Janika Neuberger [:janika]]

Fixed by Bug 1837161. The City and and state are now captured in address the save address doorhanger

Comment 5

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in the latest Nightly build 138.0a1(2025-03-21).