1874136 - Running crash tests locally shows "Welcome back" popup

Status: RESOLVED WORKSFORME

(Firefox :: Messaging System, defect, P1)

Description

[Jens Stutte [:jstutte]]

Attachment: Welcome back Popup

If I run MOZ_DISABLE_NONLOCAL_CONNECTIONS=0 mach crashtest docshell/base/crashtests/1341657.html locally, I get the attached popup. I do not think that this should happen?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:jprickett, since you are the author of the regressor, bug 1831144, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Jens Stutte [:jstutte]]

(that I need MOZ_DISABLE_NONLOCAL_CONNECTIONS=0 to run them locally is a different piece of cake)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1831144

Comment 4

[Jens Stutte [:jstutte]]

FWIW, I see this only on my linux environment, on my Windows machine it works as expected and it seems to also work for others on linux. Not sure what is the trigger then.

Comment 5

[Jason Prickett]

We have some guardrails in place to prevent this message from appearing in tests, but it seems that we might not have caught all of the edge cases. Specifically, we are checking the values of the MOZ_AUTOMATION environment variable, Cu.isInAutomation, and Services.env.exists("XPCSHELL_TEST_PROFILE_DIR"). If any of these values are truthy, the message is supposed to be prevented from being displayed. Additionally, the message should not be displayed unless the profile is > 28 days old. I suspect that there might be something happening on linux causing that. I'll do some testing on my linux machine to see if I can recreate the issue.

Comment 6

[Jens Stutte [:jstutte]]

Thanks. Maybe my profile was just > 28 days old, I am not running the built browser very often there.

Comment 7

[Jens Stutte [:jstutte]]

(In reply to Jens Stutte [:jstutte] from comment #6)

Thanks. Maybe my profile was just > 28 days old, I am not running the built browser very often there.

But it continues to do so also in subsequent runs, so not sure if that matters.

Comment 8

[Donal Meehan [:dmeehan]]

:Jason Prickett any updates from Comment 5?
Wondering if this indicates any user facing issue or is only an issue with tests?

Comment 9

[Jason Prickett]

I don't believe this is a user-facing issue. The message is indeed meant to appear for users that meet the criteria for it to appear, but the issue is that it is sometimes also appearing in certain circumstances in automation, such as this crash test, where there shouldn't be a message interrupting the flow of the automation. Nonetheless, I believe it warrants fixing, and I'll try and get to the bottom of it before the code freeze this week, however I'm having difficulty reproducing this locally.

:jstutte Silly question, but am I correct in assuming that the build you're running the crash test on is an up-to-date nightly build?

Comment 10

[Jens Stutte [:jstutte]]

(In reply to Jason Prickett from comment #9)

:jstutte Silly question, but am I correct in assuming that the build you're running the crash test on is an up-to-date nightly build?

Yes, as of the time of filing the bug.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1831144

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:pdahiya, could you have a look please?

For more information, please visit BugBot documentation.

Comment 13

[Punam Dahiya [:pdahiya]]

Setting severity to S3 as per #comment 9 issue being not user facing and so far seen in automation tests

Comment 14

[Jason Prickett]

:jstutte I've been unable to recreate this across multiple attempts. If this is still reoccurring, please re-open this bug and I'll give it another look!