Closed Bug 1874167 Opened 5 months ago Closed 1 month ago

Update indexmap, hashbrown and related crates.

Categories

(Core :: CSS Parsing and Computation, task)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: emilio, Assigned: ErichDonGubler)

References

Details

(Whiteboard: [sp3])

Attachments

(4 obsolete files)

No description provided.

I want to use some indexmap 2 feature for bug 1874050, so this would
help. Patch hashbrown 0.13 to 0.14 until fallible_collections updates.

Re-vendoring in a separate patch for ease of review, since we import
the zerocopy crate and that is a rather big diff.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

Filed https://github.com/google/zerocopy/issues/775 on the huge amount
of zerocopy tests.

Depends on D198269

Otherwise geckodriver doesn't build without the previous patch.

This basically cherry-picks:

https://github.com/ebarnard/rust-plist/commit/422933e4726f82d8726872c574cb954529c89691

And can be avoided when we update plist to 1.6. But that requires newer
time, which requires newer neqo and newer chrono, which pulls in newer
windows crates, and has a different xml parser... So another time.

Depends on D198270

Attachment #9372237 - Attachment is obsolete: true
Attachment #9372237 - Attachment is obsolete: false
Attachment #9372382 - Attachment description: Bug 1874167 - Patch hashbrown to avoid allocator-api2 import. r=glandium! → Bug 1874167 - Manual patches on top of the vendored code. r=glandium!
Attachment #9372254 - Attachment is obsolete: true
Whiteboard: [sp3]
See Also: → 1894792

I have patches in bug 1893057 that will be taking care of this. Re-assigning to myself, commandeering patches, and abandoning them.

Assignee: emilio → egubler
Depends on: 1893057
Attachment #9372382 - Attachment is obsolete: true
Attachment #9372238 - Attachment is obsolete: true
Attachment #9372237 - Attachment is obsolete: true

This is now resolved with by patches with the bug blocking it.

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: