Closed
Bug 1874179
Opened 6 months ago
Closed 6 months ago
Reuse previous buffer in JitRuntime::allocateIonOsrTempData if possible
Categories
(Core :: JavaScript Engine: JIT, task)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
123 Branch
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This can get rid of a ton of malloc/free calls on workloads involving generators. See bug 1870552 comment 3.
Even on Speedometer 3 this gets rid of most of the allocations here, although there likely aren't enough calls for it to make a measurable difference.
|
Assignee | |
Comment 1•6 months ago
|
||
This can get rid of a lot of malloc/free calls especially on workloads involving
generators or async functions, because we currently rely on OSR until we have
full Warp support for generators and async functions.
These malloc/free calls were showing up in a profile in bug 1870552.
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9373abd07b6 Try to reuse previous allocation in JitRuntime::allocateIonOsrTempData. r=iain
|
||
Comment 3•6 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox123:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
|
||
Comment 4•5 months ago
|
||
2.6% improvement on AWFY-ARES6-Basic_steadyState and improvements on other sub-tests.
You need to log in
before you can comment on or make changes to this bug.
Description
•