Closed Bug 1874241 Opened 1 year ago Closed 1 year ago

Make recordings cache current draw target rather than include for each event

Categories

(Core :: Graphics, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox123 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

Attachments

(1 file)

Most of the time when we record an event, it is for the same DrawTarget that we just used. We could save a good chunk of recording size by adding a new event RecordedSetCurrentDrawTarget to set the current DrawTarget whenever it changes and make all of the other events use the current draw target.

Since most draw commands in a recording reference the same DrawTarget
over and over again, it saves a lot of space in the recording buffer to
create a dedicated RecordedSetCurrentDrawTarget command which caches the
current DrawTarget pointer and each subsequent command that needs a
DrawTarget will use the current.

Depends on D198295

Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8872820f3964 Cache current DrawTarget in recordings. r=gfx-reviewers,lsalzman
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
Regressions: 1929911
Regressions: 1929461
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: