Closed
Bug 1874276
Opened 2 years ago
Closed 2 years ago
Convert PlacesFeed.jsm into an ESM
Categories
(Firefox :: New Tab Page, task, P2)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
124 Branch
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Whiteboard: [esmification-timeline] )
Attachments
(2 files)
PlacesFeed uses the injection system in its unit test which is incompatible with ESMs. This means that prior to converting the module, we must convert PlacesFeed.test.js into an xpcshell test. This bug covers doing both things.
|
Assignee | |
Updated•2 years ago
|
Whiteboard: [esmification-timeline]
|
|
Assignee | |
Updated•2 years ago
|
Summary: Convert PlacessFeed.jsm into an ESM → Convert PlacesFeed.jsm into an ESM
Severity: -- → S3
Priority: -- → P2
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → mconley
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D199359
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e252a267b807
Convert PlacesFeed.test.js to an xpcshell test. r=thecount,places-reviewers
https://hg.mozilla.org/integration/autoland/rev/071caeacf07c
Convert PlacesFeed into an ESM. r=thecount,places-reviewers
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e252a267b807
https://hg.mozilla.org/mozilla-central/rev/071caeacf07c
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox124:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•