1874282 - warning: the object size sanitizer has no effect at -O0, but is explicitly enabled

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, enhancement)

Description

[Jesse Schwartzentruber (:truber)]

Building with --enable-undefined-sanitizer and --disable-optimize results in warnings on every call to clang or clang++.

For example:

 0:18.38 accessible/generic                                                                                                                                                                                                                                                      
 0:18.39 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.39 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.40 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.40 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.42 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.42 accessible/html                                                                                                                                                                                                                                                         
 0:18.43 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.45 clang++: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                
 0:18.46 clang++: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                
 0:18.47 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.47 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.48 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.49 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.50 accessible/ipc                                                                                                                                                                                                                                                          
 0:18.51 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.53 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.53 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.54 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.54 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.55 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.57 clang: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                  
 0:18.57 clang++: warning: the object size sanitizer has no effect at -O0, but is explicitly enabled: -fsanitize=bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound [-Winvalid-command-line-argument]                                

We should disable the object-size sanitizer when --disable-optimize or --enable-optimize=-O0 is used.

Comment 1

[Jesse Schwartzentruber (:truber)]

Attachment: Bug 1874282 - Disable object-size sanitizer when optimize is disabled. r?#firefox-build-system-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf4441526ab0
Disable object-size sanitizer when optimize is disabled. r=firefox-build-system-reviewers,glandium

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bf4441526ab0