1874289 - "Nightly" showing in Linux dock for "release" .deb

Status: VERIFIED FIXED

(Firefox Build System :: Third Party Packaging, defect, P1)

Description

[Gabriel Bustamante [:gabriel]]

Attachment: Screenshot from 2024-01-11 15-35-23.png

I noticed "Nightly" is being used as the icon's name on the GNOME Ubuntu dock for the "release" channel .deb package. The .desktop file looks malformed.

Comment 1

[Gabriel Bustamante [:gabriel]]

Attachment: Bug 1874289 - Fix .deb package branding on release r?jlorenzo

Comment 2

[Johan Lorenzo [:jlorenzo]]

[Tracking Requested - why for this release]: We will ship the .deb package in Firefox 122. The Release branding is busted without this patch. Shipping with this bug would provide a first bad impression to users and to the tech press.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fb76a7cbc3f
Fix .deb package branding on release r=jlorenzo DONTBUILD

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 9372639 [details]
Bug 1874289 - Fix .deb package branding on release r?jlorenzo

Beta/Release Uplift Approval Request

• User impact if declined: We will ship the .deb package in Firefox 122. The Release branding is busted without this patch. Shipping with this bug would provide a first bad impression to users and to the tech press.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Download the .deb package

2. sudo dpkg -i firefox.deb
3. See the name of the installed package.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple if-statement specific to release builds. That's why we can't test it on Nightly.
• String changes made/needed: None
• Is Android affected?: No

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9372639 [details]
Bug 1874289 - Fix .deb package branding on release r?jlorenzo

Approved for 122.0 RC1

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/161951b5fd6a

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/7fb76a7cbc3f

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Hello! We tried to verify this but unfortunately, we can still see the Nightly name being used inside the Applications and Linux bar/ start bar. Please see the attached screenshot. Tested with Firefox 122.0 (20240115163159) on Ubuntu 22, Ubuntu 20, Debian 10, and Linux Mint21. Should we reopen this issue?

Comment 9

[Gabriel Bustamante [:gabriel]]

Attachment: Bug 1874289 - Fix .deb package branding on release-rc r?jlorenzo

Comment 10

[Gabriel Bustamante [:gabriel]]

I took a look at the Rpk-deb task on treeherder:

https://treeherder.mozilla.org/jobs?repo=mozilla-release&searchStr=Rpk-deb&selectedTaskRun=M__aQWLhTvSRzccdQz49_Q.0

Then at the Decision task that scheduled it:

https://firefox-ci-tc.services.mozilla.com/tasks/N18AwGreTmqfazWjsPDhGg#artifacts

The parameters on this Decision pass in release_type: release-rc

Comment 11

[Gabriel Bustamante [:gabriel]]

:dmeehan this is still an issue with the RC. I patched it here - but it won't work until it is in mozilla-release

Comment 12

[Donal Meehan [:dmeehan]]

:gabriel, can you land this and request a release uplift?
We can include it in a 122 RC2, I likely have a driver for a respin anyways

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dac397c6c092
Fix .deb package branding on release-rc r=jlorenzo

Comment 14

[Gabriel Bustamante [:gabriel]]

Attachment: Bug 1874289 - Fix .deb package branding on release-rc r?jlorenzo

Original Revision: https://phabricator.services.mozilla.com/D198694

Comment 15

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: Low
• String changes made/needed: No
• Steps to reproduce for manual QE testing: 1. Download the .deb package 2. sudo dpkg -i firefox.deb 3. See the name of the installed package.
• Is Android affected?: no
• Fix verified in Nightly: no
• Code covered by automated testing: yes
• Explanation of risk level: Simple if-statement specific to release builds. That's why we can't test it on Nightly.
• User impact if declined: We will ship the .deb package rc in Firefox 122. The Release branding is busted without this patch. Shipping with this bug would provide a first bad impression to users and to the tech press.
• Needs manual QE test: yes

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dac397c6c092

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/6f23f4fe8e1b

Comment 18

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified the issue with Firefox 122.0 RC2 .deb (20240118164516) on Ubuntu 20.04, Ubuntu 22.04, Mint 21, Debian 10 and Lubuntu 20. Firefox name is displayed after installing the .deb package.

Since 123 can be only verified on Release and we cannot verify this on Nightly we will reverify this again when 123 is on Release.

As a side note: The Nightly name remains displayed inside Show Applications but this happens only if we installed the 122.0 RC2 fixed version over the affected one (122.0 RC1). The issue goes away after a restart or after a complete uninstall and reinstall of the Firefox .deb package. Please let us know if a new issue is required for this scenario.

Comment 19

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified the issue with Firefox 123.0 .deb (20240212203859) on Ubuntu 22.04, Mint 21, Debian 12, and Lubuntu 22. Firefox name is displayed after installing the .deb package.