1874291 - Don't include directory in `browser/components/urlbar/tests/browser/browser.toml`

Status: NEW

(Testing :: General, defect, P2)

Description

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

In browser/components/urlbar/tests/browser/browser.toml, this line ends up symlinking from the object directory to a directory in the source directory. When the symlink is iterated by build manifest processing, this ends up deleting entries in the source directory. This is exactly the situation documented here. Yikes!

There are two parts to this ticket. The first is simply to update the offending line, perhaps to

["browser_recentsearches.js"]
support-files = ["search-engines/*"]

which works for me locally. The second and more important part is to ensure that support-files (and similar invocations) reject directories entirely. I don't know where the latter should be enforced.

Comment 1

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

I found this while trying to improve mach test performance on Windows as part of Bug 1867834 (but there's no particular dependency relationship).

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I am not sure how this is regressed by bug 1821199. I think this was an issue with .ini manifests previously. I assume this is only when running locally via ./mach test ... ?