1874365 - Implement the "browsingContext.downloadWillBegin" event

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This bug implements the browsingContext.downoadWillBegin event by following the HTML spec:
https://html.spec.whatwg.org/#populating-a-session-history-entry:webdriver-bidi-download-started

It needs to be emitted when the response has a Content-Disposition header specifying the attachment disposition type.

Comment 3

[Julian Descottes [:jdescottes]]

Moving to m17 for planning as this blocks many PW tests.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: download_page.html

Comment 5

[Julian Descottes [:jdescottes]]

I think there is currently a spec issue with download attributes: https://github.com/w3c/webdriver-bidi/issues/980

They should not trigger the event, but 1/ that's what we use in wdspec tests, 2/ I imagine that's what users would expect

Comment 6

[Julian Descottes [:jdescottes]]

The suggestedFilename as expected by our wdspec tests (and as implemented by Chrome) seems odd. In case you download a file with the same filename several times, it doesn't include the potential modification made to the filename by the browser (eg file.txt, file (1).txt, file (2).txt etc...)

https://github.com/w3c/webdriver-bidi/issues/982

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874365 - [wdspec] Update download_will_begin test to use different filenames

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874365 - [bidi] Add support for browsingContext.downloadWillBegin

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874365 - [remote] Declare NavigationManager events in a single enum

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874365 - [wdspec] Additional tests for browsingContext.downloadWillBegin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6828aa72a621
https://hg.mozilla.org/integration/autoland/rev/d3fccb383a63
[wdspec] Update download_will_begin test to use different filenames r=webdriver-reviewers,whimboo
https://github.com/mozilla-firefox/firefox/commit/d82e2685cb63
https://hg.mozilla.org/integration/autoland/rev/aa71ab36fed0
[bidi] Add support for browsingContext.downloadWillBegin r=webdriver-reviewers,whimboo
https://github.com/mozilla-firefox/firefox/commit/b75cb4b40bf0
https://hg.mozilla.org/integration/autoland/rev/f86f87aac557
[remote] Declare NavigationManager events in a single enum r=webdriver-reviewers,whimboo
https://github.com/mozilla-firefox/firefox/commit/0e335bfed1df
https://hg.mozilla.org/integration/autoland/rev/409d73c80929
[wdspec] Additional tests for browsingContext.downloadWillBegin r=webdriver-reviewers,whimboo

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54520 for changes under testing/web-platform/tests

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8051fc73806f
https://hg.mozilla.org/integration/autoland/rev/5931ea2513eb
Revert "Bug 1874365 - [wdspec] Additional tests for browsingContext.downloadWillBegin r=webdriver-reviewers,whimboo" for causing wd failures @download_will_begin.py.

Comment 14

[agoloman]

Backed out for causing wd failures @download_will_begin.py.

• Backout link
• Push with failures
• Failure Log

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/70e3b2ff9ca5
https://hg.mozilla.org/integration/autoland/rev/f30aef777f09
[wdspec] Update download_will_begin test to use different filenames r=webdriver-reviewers,whimboo
https://github.com/mozilla-firefox/firefox/commit/6af733da3297
https://hg.mozilla.org/integration/autoland/rev/2553c99d7d93
[bidi] Add support for browsingContext.downloadWillBegin r=webdriver-reviewers,whimboo
https://github.com/mozilla-firefox/firefox/commit/9779d6884d74
https://hg.mozilla.org/integration/autoland/rev/4623a8aa7183
[remote] Declare NavigationManager events in a single enum r=webdriver-reviewers,whimboo
https://github.com/mozilla-firefox/firefox/commit/38d2a6fb0eec
https://hg.mozilla.org/integration/autoland/rev/f5f51ea80680
[wdspec] Additional tests for browsingContext.downloadWillBegin r=webdriver-reviewers,whimboo

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54542 for changes under testing/web-platform/tests

Comment 18

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f30aef777f09
https://hg.mozilla.org/mozilla-central/rev/2553c99d7d93
https://hg.mozilla.org/mozilla-central/rev/4623a8aa7183
https://hg.mozilla.org/mozilla-central/rev/f5f51ea80680

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot