1874376 - Use latin-1 external string in XPCConvert with T_UTF8STRING is possible

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Description

[Tooru Fujisawa [:arai]]

similar to bug 1869687, but for UTF-8.
bug 1869726 will add xpc functions to convert UTF-8 string to external string if possible.
XPCConvert::NativeData2JS and XPCConvert::JSData2Native with nsXPTType::T_UTF8STRING can use them.

here's a result with prototype:

when starting up browser, there are:

• 932 calls to NativeData2JS with T_UTF8STRING
  • 258 of them are nsStringBuffer with ASCII, and can use latin-1 external string (doesn't fit inline string)
    • total 28612 bytes of string data can be shared
  • 24 of them are literal string with ASCII, and can use latin-1 external string (doesn't fit inline string)
    • total 1837 bytes of string data can be shared
• 2346 calls to JSData2Native with T_UTF8STRING
  • 38 of them are latin-1 external string created by the prototype
    • total 2941 bytes of string data can be shared

when opening YouTube top page after startup:

• 676 calls to NativeData2JS with T_UTF8STRING
  • 609 of them are nsStringBuffer with ASCII, and can use latin-1 external string (doesn't fit inline string)
    • total 91696 bytes of string data can be shared
  • 1 of them are literal string with ASCII, and can use latin-1 external string (doesn't fit inline string)
    • total 145 bytes of string data can be shared
• 1293 calls to JSData2Native with T_UTF8STRING
  • 7 of them are latin-1 external string created by the prototype
    • total 168 bytes of string data can be shared

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1874376 - Use latin-1 external string in XPCConvert with T_UTF8STRING is possible. r?nika!

Depends on D198062

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/798348b12f54
Use latin-1 external string in XPCConvert with T_UTF8STRING is possible. r=nika

Comment 3

[Atila Butkovits]

Backed out for causing build bustages at xpcpublic.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/53d4d65c33f1a556689dd9de738b173142e52749

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=798348b12f54254c1e73bbd88e57416b4f8f3baf&selectedTaskRun=Ry2o4yvQTBOmsgwHsM_KqA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=443174407&repo=autoland&lineNumber=15282

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d4152f6f05d
Use latin-1 external string in XPCConvert with T_UTF8STRING is possible. r=nika

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3d4152f6f05d

Comment 6

[Tooru Fujisawa [:arai]]

backed out by bug 1878862 patch.
This needs to handle malformed UTF-8 string, by extending XPCStringConvert::UTF8ToJSVal.

Comment 7

[Tooru Fujisawa [:arai]]

Also backed out from 123 beta.

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1874376 - Part 1: Add JS_NewMaybeExternalStringLossyUTF8. r?sfink!

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1874376 - Part 2: Add JS_NewStringCopyLossyUTF8N. r?sfink!

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1874376 - Part 3: Add XPCStringConvert::LossyUTF8ToJSVal. r?nika!

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1874376 - Part 4: Use latin-1 external string in XPCConvert with T_UTF8STRING if possible, with lossy conversion on fallback path. r=nika!

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1874376 - Use latin-1 external string in XPCConvert with T_UTF8STRING is possible. r?nika!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b778b4b9d36f
Use latin-1 external string in XPCConvert with T_UTF8STRING is possible. r=nika

Comment 14

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b778b4b9d36f

Comment 15

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b778b4b9d36f