1874394 - Prototype WPT push subscription tests

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, task)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

We should be able to use the existing python server infra in WPT to handle the subscription request, and let the test script communicate with that server to trigger push messages.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1874394 - Add basic subscription test with dummy push server r=jgraham!,asuth!

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Do you think we can allow mozilla push server connection in WPT? Having a dummy server allows WPT+/mozilla to be self-contained without external dependency, but then it may miss important interop issues caused by the server implementation. Currently I have to run the test with ./mach wpt-serve; ./mach run to make sure the test runs with the actual server, I'd be happy if we at least have some opt-in parameter so that I can run ./mach wpt with the actual server.

Comment 4

[James Graham [:jgraham]]

At the moment we're just setting MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 c.f. https://searchfox.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/utils.py#141 so practically we'd need some way to make the actual server look like a local connection for the sake of the check in https://searchfox.org/mozilla-central/source/netwerk/base/nsSocketTransport2.cpp#1275-1277. If we could do that via a pref we could arrange for the pref to be set for specific tests.

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1874394 - Add basic subscription test with dummy push server r=jgraham!,asuth!

This adds:

1. A dummy Python websocket server as a push service, which then opens a new HTTP server as a push endpoint for each subscription.

• This is done because we do not allow networking with external servers for WPT.

2. A encryption helper library that follows multiple web push RFCs.

• This is done because:
  1. Existing https://github.com/web-push-libs/web-push and https://github.com/web-push-libs/encrypted-content-encoding/ includes multiple codes that WPT don't need (e.g. multiple rs and legacy protocol support) and hard to read along with the specs.
  2. We want to generate intentionally ill-encrypted data for testing, which is harder with a third party dependency

Known caveats:

• The dummy server works but contradicts to the point for encryption; the dummy doesn't validate VAPID and implementing that part will make way more complexity with no actual extra test coverage.
  • We might instead want to somehow allow connection to the push server than adding a dummy server.
• Other servers don't send CORS headers which this test depends on

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34aec3a048ad
Add basic subscription test with dummy push server r=jgraham,asuth

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49143 for changes under testing/web-platform/tests

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/34aec3a048ad

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot