Closed
Bug 187442
Opened 22 years ago
Closed 21 years ago
change PL_strcmp to strcmp in nsIOService
Categories
(Core :: Networking, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file, 1 obsolete file)
661 bytes,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
nsIOService::SetOffline for the going offline case does this: mOffline = PR_TRUE; // indicate we're trying to shutdown // don't care if notification fails observerService->NotifyObservers(...,"network:offline-about-to-go-offline",...); // be sure to try and shutdown both (even if the first fails) rv1 = mDNSService->Shutdown(); // shutdown dns service first, because it has callbacks for socket transport rv2 = mSocketTransportService->Shutdown(); if (NS_FAILED(rv1)) return rv1; if (NS_FAILED(rv2)) return rv2; // don't care if notification fails observerService->NotifyObservers(...,"network:offline-status-changed",...); This means that if one of the two services fail to shutdown any observer that happens to listen for this stuff will think it's still in about to go offline. -- nsIOService::Observe for ... NS_XPCOM_SHUTDOWN_OBSERVER_ID: SetOffline(PR_TRUE); mFileTransportService->Shutdown(); // Break circular reference. mProxyService = nsnull; Ok, so what does it this observer do? we're in XPCOM shutdown, but it feels it's a good idea to call SetOffline. SetOffline of course needs to create the observer service to do anything useful. That of course *fails* because xpcom has stopped allowing access to getService.
Attachment #110490 -
Flags: superreview?(darin)
Attachment #110490 -
Flags: review?(darin)
Comment 2•21 years ago
|
||
Comment on attachment 110490 [details] [diff] [review] cleanup some of this has been done, but some parts of this patch look like they could still be useful. care to rev the patch? thanks in advance!
Attachment #110490 -
Flags: superreview?(darin)
Attachment #110490 -
Flags: superreview-
Attachment #110490 -
Flags: review?(darin)
Attachment #110490 -
Flags: review-
well, the logic changed, so all that's left is a useless change
Attachment #110490 -
Attachment is obsolete: true
Comment on attachment 126139 [details] [diff] [review] remnant if you don't want it feel free to kill the bug
Attachment #126139 -
Flags: superreview?(darin)
Attachment #126139 -
Flags: review?(darin)
Comment 5•21 years ago
|
||
Comment on attachment 126139 [details] [diff] [review] remnant oh, is that all that's left? heh, ok... r+sr=darin ;)
Attachment #126139 -
Flags: superreview?(darin)
Attachment #126139 -
Flags: superreview+
Attachment #126139 -
Flags: review?(darin)
Attachment #126139 -
Flags: review+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Summary: nsIOService::Observe/nsIOService::SetOffline are a bit silly → change PL_strcmp to strcmp in nsIOService
V: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsIOService.cpp&branch=&root=/cvsroot&subdir=mozilla/netwerk/base/src&command=DIFF_FRAMESET&rev1=1.161&rev2=1.162
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•