Closed Bug 1874444 Opened 2 years ago Closed 1 year ago

Crash in [@ mozilla::net::ProxyAutoConfig::SetupJS] with MOZ_DIAGNOSTIC_ASSERT(!GetRunning()) (JIT is running)

Categories

(Core :: Networking: Proxy, defect, P3)

Product:
Core
Component:
Networking: Proxy
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: mccr8, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: crash, Whiteboard: [necko-triaged])

Crash Data

Crash report: https://crash-stats.mozilla.org/report/index/547da8cd-9712-4bcf-84a2-ff7690240112

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(!GetRunning()) (JIT is running)

Top 10 frames of crashing thread:

0  XUL  mozilla::net::ProxyAutoConfig::SetupJS  netwerk/base/ProxyAutoConfig.cpp:528
1  XUL  mozilla::net::ProxyAutoConfig::GetProxyForURI  netwerk/base/ProxyAutoConfig.cpp:635
2  XUL  mozilla::net::ProxyAutoConfig::GetProxyForURIWithCallback  netwerk/base/ProxyAutoConfig.cpp:628
3  XUL  mozilla::net::nsPACMan::ProcessPending  netwerk/base/nsPACMan.cpp:860
4  XUL  mozilla::net::nsPACMan::ProcessPendingQ  netwerk/base/nsPACMan.cpp:787
4  XUL  mozilla::net::ExecutePACThreadAction::Run  netwerk/base/nsPACMan.cpp:294
5  XUL  nsThread::ProcessNextEvent  xpcom/threads/nsThread.cpp:1193
5  XUL  NS_ProcessNextEvent  xpcom/threads/nsThreadUtils.cpp:480
6  XUL  mozilla::SpinEventLoopUntil<  xpcom/threads/SpinEventLoopUntil.h:176
6  XUL  mozilla::net::ProxyAutoConfig::ResolveAddress  netwerk/base/ProxyAutoConfig.cpp:265

I only see a single instance of this crash in the last 6 months, but maybe it is interesting. It was added in bug 1780094. Outside of a diagnostic assert, it returns failure so the behavior should still be safe.

Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged][necko-priority-new]

We'll switch to a RELEASE_ASSERT since if this fails the proxy won't be installed; this will let us also see if this is common issue (in which case we'd prioritize it)

Assignee: nobody → rjesup
Whiteboard: [necko-triaged][necko-priority-new] → [necko-triaged][necko-priority-queue]

After looking more, if this returns an error in release that means that we've already done the setup, and we'll continue to install the proxy.

Severity: S3 → S4
Priority: P2 → P3
Whiteboard: [necko-triaged][necko-priority-queue] → [necko-triaged]

Moving bug to Core/Networking: Proxy.

Assignee: rjesup → nobody
Component: Networking → Networking: Proxy

Closing because no crashes reported for 12 weeks.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.