Closed
Bug 1874449
Opened 2 years ago
Closed 2 years ago
Add diagnostic assert that not canvas for remaining uses of RecordedDrawTargetCreation
Categories
(Core :: Graphics: Canvas2D, task, P3)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
123 Branch
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
Details
Attachments
(1 external file)
This crash should not be possible:
https://crash-stats.mozilla.org/report/index/b3bb13fd-a439-4d99-bb1f-c3dd50240112
Since we have a diagnostic assert on the content process side here:
https://searchfox.org/mozilla-central/rev/f465027ef4d334dbc9ad270718c8a5e8045e7a2b/gfx/2d/DrawTargetRecording.cpp#212
The only other use of RecordedDrawTargetCreation is:
https://searchfox.org/mozilla-central/rev/f465027ef4d334dbc9ad270718c8a5e8045e7a2b/gfx/2d/DrawTargetRecording.cpp#784
Which should be very impossible as this is only used by the blob image recording infrastructure.
Let's add another diagnostic assert to get to the bottom of this, because we cannot diagnose this from the compositor process crashes.
| Assignee | ||
Comment 1•2 years ago
|
||
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2721a604018b
Add diagnostic assert that not for canvas for use of RecordedDrawTargetCreation. r=gfx-reviewers,lsalzman
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox123:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•