1874454 - Implement GetHeterogeneousCpuInfo for Apple Silicon Mac

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

Right now it is implemented for Android only but we could utilize the information also on Macs.
Separate bug could be filed for Windows and Linux (though there we need to be very careful what to do with the data, since there are so many different types of cpus these days).

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1874454 - Implement GetHeterogeneousCpuInfo for Apple Silicon Mac, r=haik

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f0edda611cf
Implement GetHeterogeneousCpuInfo for Apple Silicon Mac, r=haik,mstange

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing bp-nu bustages in CocoaHeterogeneousCpuInfo.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/hal/cocoa/CocoaHeterogeneousCpuInfo.cpp:14:16: error: use of undeclared identifier 'HeterogeneousCpuInfo'

Comment 4

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/7f4a0f8df448

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

uh, unified builds

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/befc4b3f9f97
Implement GetHeterogeneousCpuInfo for Apple Silicon Mac, r=haik,mstange

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/befc4b3f9f97

Comment 8

[Alex Finder]

(In reply to Pulsebot from comment #6)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/befc4b3f9f97
Implement GetHeterogeneousCpuInfo for Apple Silicon Mac, r=haik,mstange
== Change summary for alert #41121 (as of Tue, 23 Jan 2024 12:52:06 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
3%	speedometer3	macosx1300-64-shippable-qr	fission webrender	28.79 -> 29.69	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=41121