Closed Bug 1874484 Opened 2 years ago Closed 2 years ago

Perma Windows MinGW [tier 2] / --disable-webrtc /builds/worker/checkouts/gecko/dom/media/MediaTrackGraph.cpp:2288:21: error: member access into incomplete type 'const AudioDeviceInfo'

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P5)

defect

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox121 --- unaffected
firefox122 --- unaffected
firefox123 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: karlt)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 external file)

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=443157190&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aqLLz5-BSUCVe0YYlIetsg/runs/0/artifacts/public/logs/live_backing.log


[task 2024-01-12T20:15:17.685Z] 20:15:17  WARNING -  /builds/worker/workspace/obj-build/dist/include/mozilla/AwakeTimeStamp.h:100:3: warning: 'dllimport' attribute ignored on inline function [-Wignored-attributes]
[task 2024-01-12T20:15:17.685Z] 20:15:17     INFO -    100 |   MFBT_API bool operator==(const AwakeTimeDuration& aOther) const {
[task 2024-01-12T20:15:17.686Z] 20:15:17     INFO -        |   ^
[task 2024-01-12T20:15:17.686Z] 20:15:17     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:101:24: note: expanded from macro 'MFBT_API'
[task 2024-01-12T20:15:17.686Z] 20:15:17     INFO -    101 | #      define MFBT_API MOZ_IMPORT_API
[task 2024-01-12T20:15:17.686Z] 20:15:17     INFO -        |                        ^
[task 2024-01-12T20:15:17.686Z] 20:15:17     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:63:39: note: expanded from macro 'MOZ_IMPORT_API'
[task 2024-01-12T20:15:17.687Z] 20:15:17     INFO -     63 | #    define MOZ_IMPORT_API __declspec(dllimport)
[task 2024-01-12T20:15:17.687Z] 20:15:17     INFO -        |                                       ^
[task 2024-01-12T20:15:17.687Z] 20:15:17     INFO -  In file included from Unified_cpp_dom_media3.cpp:2:
[task 2024-01-12T20:15:17.687Z] 20:15:17     INFO -  In file included from /builds/worker/checkouts/gecko/dom/media/MediaPlaybackDelayPolicy.cpp:10:
[task 2024-01-12T20:15:17.687Z] 20:15:17     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/HTMLMediaElement.h:17:
[task 2024-01-12T20:15:17.687Z] 20:15:17     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/TelemetryProbesReporter.h:10:
[task 2024-01-12T20:15:17.688Z] 20:15:17  WARNING -  /builds/worker/workspace/obj-build/dist/include/mozilla/AwakeTimeStamp.h:103:3: warning: 'dllimport' attribute ignored on inline function [-Wignored-attributes]
[task 2024-01-12T20:15:17.688Z] 20:15:17     INFO -    103 |   MFBT_API bool operator!=(const AwakeTimeDuration& aOther) const {
[task 2024-01-12T20:15:17.688Z] 20:15:17     INFO -        |   ^
[task 2024-01-12T20:15:17.688Z] 20:15:17     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:101:24: note: expanded from macro 'MFBT_API'
[task 2024-01-12T20:15:17.688Z] 20:15:17     INFO -    101 | #      define MFBT_API MOZ_IMPORT_API
[task 2024-01-12T20:15:17.689Z] 20:15:17     INFO -        |                        ^
[task 2024-01-12T20:15:17.689Z] 20:15:17     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:63:39: note: expanded from macro 'MOZ_IMPORT_API'
[task 2024-01-12T20:15:17.689Z] 20:15:17     INFO -     63 | #    define MOZ_IMPORT_API __declspec(dllimport)
[task 2024-01-12T20:15:17.689Z] 20:15:17     INFO -        |                                       ^
[task 2024-01-12T20:15:17.689Z] 20:15:17     INFO -  In file included from Unified_cpp_dom_media3.cpp:83:
[task 2024-01-12T20:15:17.690Z] 20:15:17    ERROR -  /builds/worker/checkouts/gecko/dom/media/MediaTrackGraph.cpp:2288:21: error: member access into incomplete type 'const AudioDeviceInfo'
[task 2024-01-12T20:15:17.690Z] 20:15:17     INFO -   2288 |     deviceID = aSink->DeviceID();
[task 2024-01-12T20:15:17.690Z] 20:15:17     INFO -        |                     ^
[task 2024-01-12T20:15:17.690Z] 20:15:17     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/HTMLMediaElement.h:81:7: note: forward declaration of 'AudioDeviceInfo'
[task 2024-01-12T20:15:17.690Z] 20:15:17     INFO -     81 | class AudioDeviceInfo;
[task 2024-01-12T20:15:17.690Z] 20:15:17     INFO -        |       ^
[task 2024-01-12T20:15:17.691Z] 20:15:17     INFO -  In file included from Unified_cpp_dom_media3.cpp:83:
[task 2024-01-12T20:15:17.691Z] 20:15:17    ERROR -  /builds/worker/checkouts/gecko/dom/media/MediaTrackGraph.cpp:2289:55: error: member access into incomplete type 'const AudioDeviceInfo'
[task 2024-01-12T20:15:17.691Z] 20:15:17     INFO -   2289 |     preferredSampleRate = static_cast<TrackRate>(aSink->DefaultRate());
[task 2024-01-12T20:15:17.691Z] 20:15:17     INFO -        |                                                       ^
[task 2024-01-12T20:15:17.692Z] 20:15:17     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/HTMLMediaElement.h:81:7: note: forward declaration of 'AudioDeviceInfo'
[task 2024-01-12T20:15:17.692Z] 20:15:17     INFO -     81 | class AudioDeviceInfo;
[task 2024-01-12T20:15:17.692Z] 20:15:17     INFO -        |       ^
[task 2024-01-12T20:15:17.692Z] 20:15:17     INFO -  20 warnings and 2 errors generated.
[task 2024-01-12T20:15:17.692Z] 20:15:17    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:690: Unified_cpp_dom_media3.o] Error 1
[task 2024-01-12T20:15:17.692Z] 20:15:17     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media'

:karlt, since you are the author of the regressor, bug 1869043, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(karlt)

for the record, seeing the same issue on Linux on ppc64le and s390x

...
In file included from Unified_cpp_dom_media3.cpp:83:
/home/jenkins/workspace/Firefox-default/label/s390x/firefox/dom/media/MediaTrackGraph.cpp: In member function ‘void mozilla::MediaTrack::AddAudioOutput(void*, const AudioDeviceInfo*)’:
/home/jenkins/workspace/Firefox-default/label/s390x/firefox/dom/media/MediaTrackGraph.cpp:2288:21: error: invalid use of incomplete type ‘const class AudioDeviceInfo’
 2288 |     deviceID = aSink->DeviceID();
      |                     ^~
In file included from /home/jenkins/workspace/Firefox-default/label/s390x/firefox/dom/media/MediaPlaybackDelayPolicy.cpp:10,
                 from Unified_cpp_dom_media3.cpp:2:
/home/jenkins/workspace/Firefox-default/label/s390x/firefox/obj-s390x-ibm-linux-gnu/dist/include/mozilla/dom/HTMLMediaElement.h:81:7: note: forward declaration of ‘class AudioDeviceInfo’
   81 | class AudioDeviceInfo;
      |       ^~~~~~~~~~~~~~~
/home/jenkins/workspace/Firefox-default/label/s390x/firefox/dom/media/MediaTrackGraph.cpp:2289:55: error: invalid use of incomplete type ‘const class AudioDeviceInfo’
 2289 |     preferredSampleRate = static_cast<TrackRate>(aSink->DefaultRate());
      |                                                       ^~
/home/jenkins/workspace/Firefox-default/label/s390x/firefox/obj-s390x-ibm-linux-gnu/dist/include/mozilla/dom/HTMLMediaElement.h:81:7: note: forward declaration of ‘class AudioDeviceInfo’
   81 | class AudioDeviceInfo;
      |       ^~~~~~~~~~~~~~~
gmake[4]: *** [/home/jenkins/workspace/Firefox-default/label/s390x/firefox/config/rules.mk:690: Unified_cpp_dom_media3.o] Error 1
...
Assignee: nobody → karlt
Flags: needinfo?(karlt)
Summary: Perma Windows MinGW [tier 2] /builds/worker/checkouts/gecko/dom/media/MediaTrackGraph.cpp:2288:21: error: member access into incomplete type 'const AudioDeviceInfo' → Perma Windows MinGW [tier 2] / --disable-webrtc /builds/worker/checkouts/gecko/dom/media/MediaTrackGraph.cpp:2288:21: error: member access into incomplete type 'const AudioDeviceInfo'

Previously this was indirectly included from MediaEngineWebRTCAudio.h,
only when MOZ_WEBRTC was set.

the proposed patch fixes the issue for me, thanks

Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62effcacb4ba include AudioDeviceInfo.h r=padenot,media-playback-reviewers
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch

Set release status flags based on info from the regressing bug 1869043

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: