1874488 - New wpt failures in /css/cssom-view/ [client-props-zoom.html, scroll-zoom.html]

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 43953 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

• /css/cssom-view/client-props-zoom.html [wpt.fyi]
  • Client properties for elements with css zoom 1: FAIL
• /css/cssom-view/scroll-zoom.html [wpt.fyi]
  • scroll properties for elements with css zoom 1: FAIL

CI Results

Missing results from treeherder
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1874310 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Daniel Holbert [:dholbert]]

The pull request that added this WPT (upstream) references this google doc for more info (title "DOM APIs affected by CSS zoom"):
https://docs.google.com/document/d/1AcnDShjT-kEuRaMchZPm5uaIgNZ4OiYtM4JI9qiV8Po/edit

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Yup, this is a known thing to fix before shipping. Thanks!

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1874488 - Make Element.{client,scroll} APIs zoom aware. r=#layout

Also extend scroll-zoom to cover scroll{Top,Left,To,By}, since that was
completely untested.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1874488 - Guarantee that Element::GetScrollFrame returns a frame if it returns a scrollframe. r=TYLin,#layout

This the "body propagated to root" case to also set aFrame.

This doesn't change behavior for current callers, but would be useful to
simplify the following patches.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1874488 - Refactor some scroll APIs to use shared code. r=TYLin,#layout

This makes the next patch simpler too. No behavior change.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/974683909782
Guarantee that Element::GetScrollFrame returns a frame if it returns a scrollframe. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/13da2be03857
Refactor some scroll APIs to use shared code. r=TYLin,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/467c5213a79a
Make Element.{client,scroll} APIs zoom aware. r=saschanaz,TYLin

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44452 for changes under testing/web-platform/tests

Comment 8

[Iulian Moraru]

Backed out for causing multiple failures.

• Push with failures

• Failure log for marionette failures

• Failure log for bc failures

• Backout link

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e353a8663db
Guarantee that Element::GetScrollFrame returns a frame if it returns a scrollframe. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/1557fda26451
Refactor some scroll APIs to use shared code. r=TYLin,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/fbf03aba7e9d
Make Element.{client,scroll} APIs zoom aware. r=saschanaz,TYLin

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6e353a8663db
https://hg.mozilla.org/mozilla-central/rev/1557fda26451
https://hg.mozilla.org/mozilla-central/rev/fbf03aba7e9d

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot