Closed Bug 1874627 Opened 10 months ago Closed 10 months ago

Perma security/manager/ssl/tests/unit/test_cert_expiration_canary.js | xpcshell return code: 0 | - verifying Test End-entity: should get error 0 - -8162 == 0

Categories

(Core :: Security: PSM, defect)

defect

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox-esr115 123+ fixed
firefox121 --- wontfix
firefox122 --- fixed
firefox123 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: keeler)

References

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [stockwell disabled])

Attachments

(3 files)

Filed by: sstanca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=443290634&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/NUH3bcGNQFqw8WuUVdm6fg/runs/0/artifacts/public/logs/live_backing.log


[task 2024-01-15T00:31:26.969Z] 00:31:26     INFO -  TEST-PASS | uriloader/exthandler/tests/unit/test_punycodeURIs.js | took 98ms
[task 2024-01-15T00:31:26.970Z] 00:31:26     INFO -  Retrying tests that failed when run in parallel.
[task 2024-01-15T00:31:26.971Z] 00:31:26     INFO -  TEST-START | security/manager/ssl/tests/unit/test_cert_expiration_canary.js
[task 2024-01-15T00:31:27.085Z] 00:31:27  WARNING -  TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_cert_expiration_canary.js | xpcshell return code: 0
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  TEST-INFO took 115ms
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  >>>>>>>
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  running event loop
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  security/manager/ssl/tests/unit/test_cert_expiration_canary.js | Starting
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  (xpcshell/head.js) | test pending (2)
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2024-01-15T00:31:27.086Z] 00:31:27  WARNING -  TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_cert_expiration_canary.js |  - verifying Test End-entity: should get error 0 - -8162 == 0
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  -e:null:1
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  exiting test
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  PID 6372 | JavaScript error: /opt/worker/tasks/task_170527664035023/build/tests/xpcshell/head.js, line 869: NS_ERROR_ABORT:
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "NS_ERROR_ABORT: " {file: "/opt/worker/tasks/task_170527664035023/build/tests/xpcshell/head.js" line: 869}]
[task 2024-01-15T00:31:27.086Z] 00:31:27     INFO -  _abort_failed_test@/opt/worker/tasks/task_170527664035023/build/tests/xpcshell/head.js:869:20
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  do_report_result@/opt/worker/tasks/task_170527664035023/build/tests/xpcshell/head.js:981:5
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  Assert<@/opt/worker/tasks/task_170527664035023/build/tests/xpcshell/head.js:70:21
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:244:10
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  equal@resource://testing-common/Assert.sys.mjs:286:8
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  verifyCertFinished@/opt/worker/tasks/task_170527664035023/build/tests/xpcshell/tests/security/manager/ssl/tests/unit/head_psm.js:274:10
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  _do_main@/opt/worker/tasks/task_170527664035023/build/tests/xpcshell/head.js:245:6
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  _execute_test@/opt/worker/tasks/task_170527664035023/build/tests/xpcshell/head.js:596:5
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  @-e:1:1
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  "
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  <<<<<<<
[task 2024-01-15T00:31:27.087Z] 00:31:27     INFO -  TEST-START | devtools/client/shared/remote-debugging/adb/xpcshell/test_adb.js
Summary: Perma security/manager/ssl/tests/unit/test_cert_expiration_canary.js | xpcshell return code: 0 → Perma security/manager/ssl/tests/unit/test_cert_expiration_canary.js | xpcshell return code: 0 | - verifying Test End-entity: should get error 0 - -8162 == 0

Hi Dana,
Can you please take a look? Thanks

Flags: needinfo?(dkeeler)
See Also: → 1748409
Severity: S4 → --
Priority: P5 → --
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/c99a236b215f disable test_cert_expiration_canary.js until in-tree certificates have been renewed
Pushed by chorotan@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/ae2d8becbc0b disable test_cert_expiration_canary.js until in-tree certificates have been renewed a=fix
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]

The patch is basically ready to go, but it's going to conflict with bug 1857894, which is on autoland, so I'm waiting for that.

Depends on: 1857894
Flags: needinfo?(dkeeler)
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c10e05cb733 regenerate expiring test certificates for 2024 r=jschanck,necko-reviewers,extension-reviewers,robwu,jesup
Status: NEW → RESOLVED
Closed: 10 months ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
Assignee: nobody → dkeeler

The patch landed in nightly and beta is affected.
:keeler, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(dkeeler)
  • the certificates were regenerated using ./mach generate-test-certs
  • the build/pgo/certs/ changes were made using
    ./mach python build/pgo/genpgocert.py
  • the zip files in security/manager/ssl/tests/unit/test_signed_apps/ were
    updated per the directions in the corresponding moz.build file
  • security/manager/ssl/tests/unit/test_cert_override_read.js needed manual
    updating

These certificates and other test artifacts will now expire in 2025.

Comment on attachment 9375550 [details]
Bug 1874627 - regenerate expiring test certificates for 2024 (branch patch) r?jschanck

Beta/Release Uplift Approval Request

  • User impact if declined: (test only change)
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): test only change
  • String changes made/needed: none
  • Is Android affected?: Yes

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: (test only change)
  • User impact if declined: (test only change)
  • Fix Landed on Version: 123
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): test only change
Flags: needinfo?(dkeeler)
Attachment #9375550 - Flags: approval-mozilla-release?
Attachment #9375550 - Flags: approval-mozilla-esr115?
Attachment #9375550 - Flags: approval-mozilla-beta?

Comment on attachment 9375550 [details]
Bug 1874627 - regenerate expiring test certificates for 2024 (branch patch) r?jschanck

This will ride the train to beta with Fx123

Attachment #9375550 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

Comment on attachment 9375550 [details]
Bug 1874627 - regenerate expiring test certificates for 2024 (branch patch) r?jschanck

Test-only change approved for 122.0.1

Attachment #9375550 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9375550 - Flags: approval-mozilla-esr115? → approval-mozilla-esr115+

Heads-up, the ESR115 patch here (landed in comment 23) seems to have included an unrelated change, reverting a test-fix for layout/generic/test/file_bug514732_window.xhtml which was recently uplifted in bug 1878346 -- see bug 1878346 comment 14, and this part of the patch that landed in comment 23 here:
https://hg.mozilla.org/releases/mozilla-esr115/rev/025824aab59e#l4.1

It probably makes sense to address this by re-landing over in bug 1878346, but I just wanted to post a heads-up over here as well. Fortunately the consequences weren't dire; it just meant that an intermittent test failure stuck around when it should have been fixed. :)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: