1874656 - Migrate from the parser worker `findBestMatchExpression` to use lezer for matching expressions

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Hubert Boma Manilla (:bomsy)]

To find the matching expression for a token position the preview uses findBestMatchExpression on the parserWorker https://searchfox.org/mozilla-central/rev/f465027ef4d334dbc9ad270718c8a5e8045e7a2b/devtools/client/debugger/src/actions/preview.js#29-32.

It falls back to getExpressionFromCoords https://searchfox.org/mozilla-central/rev/f465027ef4d334dbc9ad270718c8a5e8045e7a2b/devtools/client/debugger/src/actions/preview.js#36 which uses the codemirror api to match the expressions.

Lets try to move from using parserWorker.findBestMatchExpression to a utility based on the lezer parser which should give some performance.wins.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1874656 - [devtools] Move from using parserWorker.findBestMatchExpression to getExpressionFromCoords r=#devtools-reviewers

Depends on D197907

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1874656 - [devtools] Migrate to using lezer for find best match expression r=#devtools-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1af43b9ecb9
[devtools] Migrate to using lezer for find best match expression r=devtools-reviewers,nchevobbe

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/f1af43b9ecb9

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: WIP: Bug 1874656 - [devtools] Fix matching the wrong value in the member expression

Comment 6

[Phabricator Automation]

Comment on attachment 9459085 [details]
WIP: Bug 1874656 - [devtools] Fix matching the wrong value in the member expression

Revision D234011 was moved to bug 1941269. Setting attachment 9459085 [details] to obsolete.