1874665 - Distinguish between Callback and Dict in IDL

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement)

Description

[Keith Cirkel [:keithamus]]

Steps to reproduce:

Creating an IDL like dictionary Foo {}; type (VoidCallback or Foo) MyUnion; results in a compile error.

WebIDL.WebIDLError: error: Flat member types of a union should be distinguishable, VoidCallback is not distinguishable from Foo (Wrapper)

However https://github.com/whatwg/webidl/pull/1353 has now been merged, and the WebIDL generator should be updated to allow this.

Comment 1

[Keith Cirkel [:keithamus]]

Attachment: Bug 1874665 - Distinguish between Callback & Dict in WebIDL. r=peterv

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ba32a1a0cb7
Distinguish between Callback & Dict in WebIDL. r=peterv

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing linting opt failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | Should throw for 'CallbackInterface' and '(long or Callback)' because they are not distinguishable

Comment 4

[Keith Cirkel [:keithamus]]

Ack. I'll keep working on it.

Comment 5

[Daniel Bodea [:danibodea]]

This report appears to appertain to the (Core) DOM: HTML component as most of the IDL bugs. Please assign a better component if incorrect.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2c10e4e66fa
Distinguish between Callback & Dict in WebIDL. r=peterv

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e2c10e4e66fa

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e2c10e4e66fa